1484761 - Change "security certificates" to "certificates" on the new cert error pages

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[Johann Hofmann [:johannh]]

Here:

https://searchfox.org/mozilla-central/search?q=Websites%20prove%20their%20identity%20via%20security%20certificates&case=false&regexp=false&path=

Comment 1

[Trisha Gupta [:trisha]]

Hey, looks like I can take this?

Comment 2

[Johann Hofmann [:johannh]]

Hey, absolutely. Feel free to just assign yourself.

Comment 3

[Trisha Gupta [:trisha]]

Attachment: bug1484761.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=363f120ca0e33c144866a690c1eb750efa84fddb

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 9005643 [details] [diff] [review]
bug1484761.patch

Review of attachment 9005643 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99e8a7cd7726
Change "security certificates" to "certificates" on the new cert error pages r=johannh

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/99e8a7cd7726

Comment 7

[Francesco Lodolo [:flod]]

Can someone explain the rationale behind changing the first "security certificate", but not the second in the same sentence?

For example: "Websites prove their identity via certificates. %1$S does not trust %2$S because it uses a security certificate that is not valid for %2$S."

This patch is creating a lot of churn on final merge day, it would have been nice to avoid that.

Comment 8

[Francesco Lodolo [:flod]]

Talked with Johann on IRC (we need to fix also the other instances), and asked sheriffs to back this out. 

If it's needed in 63, we can request to uplift the right patch when it's ready.

Comment 9

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 99e8a7cd7726 (Bug 1484761) as requested by the developer on IRC on a CLOSED TREE

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/dd76062be73d
Backed out changeset 99e8a7cd7726 as requested by the developer on IRC on a CLOSED TREE

Comment 11

[Meridel [:meridel]]

@[e-mail], thank you for catching that. This was last-minute add and it's not critical. I've updated the copy to remove any instances of "security certificate." 

I have two small open questions in here for Dana: https://docs.google.com/document/d/1PGZFR5fpXAjwJ8B3zg7wmZENYrDL3gWj9qmetJC2XFk/edit#

Comment 12

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I left responses in the doc - let me know if I can elaborate or clarify.

Comment 13

[Trisha Gupta [:trisha]]

Attachment: bug1484761.patch

I have fixed the other instances too, please let me know if anything else needs to be done here

Comment 14

[Johann Hofmann [:johannh]]

Comment on attachment 9009613 [details] [diff] [review]
bug1484761.patch

Review of attachment 9009613 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 15

[Stefan Hindli [:stefan_hindli]]

Hello,

Patched failed to apply. This is the stuff I get in the console. Can you please take a look?

applying bug1484761.patch
patching file browser/actors/NetErrorChild.jsm
Hunk #2 FAILED at 164
1 out of 7 hunks FAILED -- saving rejects to file browser/actors/NetErrorChild.jsm.rej
patching file security/manager/locales/en-US/chrome/pipnss/pipnss.properties
Hunk #2 succeeded at 293 with fuzz 2 (offset 2 lines).
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1484761.patch

Comment 16

[Trisha Gupta [:trisha]]

Attachment: bug1484761.patch

Carrying forward r+ from previous patch. I hope this patch applies now as I re-based it

Comment 17

[Johann Hofmann [:johannh]]

Ah! This never landed! Let me do that now :)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/163c65f9c522
Change "security certificates" to "certificates" on the new cert error pages r=johannh

Comment 19

[Arthur Iakab [arthur_iakab]]

Backed out changeset 163c65f9c522 (bug 1484761)for browser chrome failures on browser_aboutCertError.js
Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/b6873a75a4693ee420c7842957894c96b3336ee2

Failed push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=163c65f9c522229c0bbc3a73055499c8b406189a

Failure log:https://treeherder.mozilla.org/logviewer.html#?job_id=204049279&repo=mozilla-inbound

:johannh could you please take a look?

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5236f47824ca
Change "security certificates" to "certificates" on the new cert error pages r=johannh

Comment 21

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5236f47824ca

Comment 22

[Damira Akh]

Verified in latest Nightly.