Open Bug 1484771 Opened 4 years ago Updated 4 years ago

Teach test harness about stackTest and oomTest

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox63 --- affected

People

(Reporter: mgaudet, Unassigned)

References

Details

Currently checked in stackTest and oomTests need to be guarded [1][2]: 
    
    if (!('oomTest' in this))
        quit();
    
or 

    if (!('stackTest' in this))
        quit();
    
However, it seems like this should be something the test harness is taking care of. 


[1]: https://searchfox.org/mozilla-central/rev/847b64cc28b74b44c379f9bff4f415b97da1c6d7/js/src/jit-test/tests/saved-stacks/bug-1445973-quick.js#22-23
https://searchfox.org/mozilla-central/rev/847b64cc28b74b44c379f9bff4f415b97da1c6d7/js/src/jit-test/tests/basic/bug1447996.js#1-2
I cannot agree more because I stopped counting the number of patches that got me backed out because I forgot to add these lines.

One simple idea would be to polyfill these functions if not present.  We might still have to add these conditions for test cases which are using these from other globals.

if (!('oomTest' in this))
    this.oomTest = () => quit();
if (!('stackTest' in this))
    this.stackTest = () => quit();

This might influence some test cases, but I think this is minor. In the worse case we should probably add a jit-test flag to strip the harness before running.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.