Closed
Bug 1484796
Opened 6 years ago
Closed 6 years ago
Add console logging to site patches via Content Scripts
Categories
(Web Compatibility :: Interventions, enhancement, P1)
Web Compatibility
Interventions
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: denschub, Assigned: denschub)
References
Details
Attachments
(1 file)
We should add console logging to site patches via content scripts for two reasons: 1. We log something into the console when we alter the User Agent, so that people are aware we did something. However, for content scripts, there is no such thing. We should log something, so web developers are aware that we altered their site in a way. 2. In bug 1484324, we broke Fenenc Beta builds because two site patches share exactly the same code. While we could use the same JS file in both cases, we decided to have one file per webcompat bug, so that managing those is easier. When adding a console logging statement, those files no longer match, so we unbreak the build with that.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9002561 [details] Bug 1484796 - Add console logging statements to site patches. r=kmag,rhelmer Kris Maglione [:kmag] has approved the revision.
Attachment #9002561 -
Flags: review+
Comment 3•6 years ago
|
||
Comment on attachment 9002561 [details] Bug 1484796 - Add console logging statements to site patches. r=kmag,rhelmer Robert Helmer [:rhelmer] has approved the revision.
Attachment #9002561 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bf437ef1af2 Add console logging statements to site patches. r=kmag,rhelmer
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9bf437ef1af2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•