1484823 - Error in jni/Types.h when building with NDK r18-beta1

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Jan Henning [:JanH]]

I didn't manage to get a build going with my system clang and the NDK clang from r17 apparently doesn't work, either (bug 1484723), so I tried building with r18-beta1.

One breaking change is that in the NDK's jni.h, all jvalue* method parameters were made const, so our jni/Types.h needs adjusting as well so clang doesn't complain.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1484823 - Fix Android build errors with NDK r18-beta1. r?snorp

Getting a working local build with the system clang might be tricky, while
building with NDK r17 clang is broken (bug 1484723).
NDK r18-beta1 fixes this, but also made all jvalue* method parameters in jni.h
const,so in order to support building with it we need to adjust our relevant
function types, too.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9002590 [details]
Bug 1484823 - Fix Android build errors with NDK r18-beta1. r?snorp

James Willcox (:snorp) ([e-mail]) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e635f336c727
Fix Android build errors with NDK r18-beta1. r=snorp

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e635f336c727

Comment 6

[Jeff Muizelaar [:jrmuizel]]

r15c doesn't have <android/ndk-version.h> so this seems to break the build there.

Comment 7

[Daosheng Mu[:daoshengmu]]

I also have trouble with r15c doesn't have <android/ndk-version.h> in Types.h. Mark it, it works.

I was trying to use r17b, Clang will crash when doing the optimized build. So, r15c is my preferred currently.

Comment 8

[Jan Henning [:JanH]]

Working on it.

Comment 9

[Jan Henning [:JanH]]

Attachment: Bug 1484823 - Use a backwards compatible way of handling NDK changes in jni.h. r?jchen

When building with the NDK clang, which is the easiest way of building locally,
NDK r17 doesn't work for ARM builds because of a broken clang, and while the
NDK r18-beta fixes that problem, for some people it causes a different set of
issues.
Since NDK r15c doesn't have the ndk-version.h headers, switch to a different
way of bridging the differences that allows people to continue building with
r15c locally.