Closed Bug 1484824 Opened 3 years ago Closed 5 months ago

ARM64: Implement Integer math codegen

Categories

(Core :: JavaScript Engine: JIT, enhancement, P2)

ARM64
Unspecified
enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- affected
firefox67 --- affected

People

(Reporter: sstangl, Assigned: sstangl)

References

(Blocks 1 open bug)

Details

There are a number of integer math codegen functions requiring implementation.

Currently, the list is as follows:

- visitDivI()
- visitDivPowTwoI()
- modICommon()
- visitModI()
- visitModMaskI()
- visitShiftI()
- visitRound()
- visitTrunc()
- visitCtzI()
- visitTruncateDToInt32()
- visitTruncateFToInt32()
- visitNotI()
- visitUDiv()
- visitUMod()
- visitNegI()
- visitAddI64()
- visitClzI64()
- visitCtzI64()
- visitMulI64()
- visitNotI64()
- visitSubI64()
- visitPopcntI()
- visitBitOpI64()
- visitShiftI64()
- visitSoftDivI()
- visitSoftModI()
- visitPopcntI64()
- visitRotateI64()
- visitCompareI64()
- visitSoftUDivorMod()
- visitSignExtendInt64()
- visitWrapInt64ToInt32()
- visitExtendInt32ToInt64()
- visitCompareI64AndBranch()

Because this code can be difficult to review, I will attempt to be helpful and break it up into smaller chunks.
Priority: -- → P2
Depends on: 1492285
Depends on: 1492302
Depends on: 1499536
Depends on: 1505193
Whiteboard: [arm64:m2]
Depends on: 1510334
Depends on: 1510735
Depends on: 1510807
Depends on: 1511447
Depends on: 1523568

Is anyone working on this issue, I nobody i can help in implementing those!

Removing [arm64:m2] whiteboard tag because this bug no longer blocks enabling Ion in Nightly. Sean says there is still some follow-up performance work to be done in the integer codegen, but the blocking parts have already been done.

Perf work is moved to bug 1712291.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.