1484868 - Add the nsIPermissionManager::removeByType() API

Status: RESOLVED FIXED

(Core :: Permission Manager, enhancement, P1)

Description

[(no longer active)]

I need this API for the implementation of the functionality in bug 1484788...

Comment 1

[(no longer active)]

Attachment: Add the nsIPermissionManager::removeByType() API

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9002625 [details] [diff] [review]
Add the nsIPermissionManager::removeByType() API

Review of attachment 9002625 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +2120,5 @@
> +        continue;
> +      }
> +
> +      nsCOMPtr<nsIPermission> permission =
> +        nsPermission::Create(principal,

It looks like we're only creating these nsIPermission objects in order to iterate over them again in a second removal pass. I think I'd prefer to just collect a 
    nsTArray<Pair<nsCString, uint32_t>>

or similar to avoid the unnecessary object creation.

That being said, I see this code was originally from another method, and I'd be OK with doing that cleanup in a follow-up :-).

Comment 3

[(no longer active)]

Filed bug 1485114 to address the review comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dade0d8f79ea
Add the nsIPermissionManager::removeByType() API; r=nika

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/dade0d8f79ea