Closed Bug 1484868 Opened 4 years ago Closed 4 years ago

Add the nsIPermissionManager::removeByType() API

Categories

(Core :: Permission Manager, enhancement, P1)

Product:
Core
Component:
Permission Manager
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Add the nsIPermissionManager::removeByType() API
10.73 KB, patch
nika
: review+
Details | Diff | Splinter Review 
I need this API for the implementation of the functionality in bug 1484788...
Blocks: 1484876
Priority: -- → P1
Comment on attachment 9002625 [details] [diff] [review]
Add the nsIPermissionManager::removeByType() API

Review of attachment 9002625 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +2120,5 @@
> +        continue;
> +      }
> +
> +      nsCOMPtr<nsIPermission> permission =
> +        nsPermission::Create(principal,

It looks like we're only creating these nsIPermission objects in order to iterate over them again in a second removal pass. I think I'd prefer to just collect a 
    nsTArray<Pair<nsCString, uint32_t>>

or similar to avoid the unnecessary object creation.

That being said, I see this code was originally from another method, and I'd be OK with doing that cleanup in a follow-up :-).
Attachment #9002625 - Flags: review?(nika) → review+
Filed bug 1485114 to address the review comment.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dade0d8f79ea
Add the nsIPermissionManager::removeByType() API; r=nika
https://hg.mozilla.org/mozilla-central/rev/dade0d8f79ea
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.