Closed Bug 1484887 Opened 6 years ago Closed 6 years ago

Graveyard Components in Core

Categories

(bugzilla.mozilla.org :: Graveyard Tasks, task)

Product:
bugzilla.mozilla.org
Component:
Graveyard Tasks
Version:
Production
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: emceeaich, Assigned: dkl)

References

Details

* Layout: Frames
* Layout: Misc Code
* Layout: View Rendering
(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #0)
> * Layout: Frames

Did you mean 'Layout: HTML Frames'?

> * Layout: Misc Code
> * Layout: View Rendering

Moved
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Flags: needinfo?(ehumphries)
Yes, that should be "Layout: HTML Frames", thanks!
Flags: needinfo?(ehumphries)
(In reply to Cameron McCormack (:heycam) from comment #2)
> Yes, that should be "Layout: HTML Frames", thanks!

Done
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Bug 1484886 needs to be resolved before this can happen. 

Did the open bugs in the above components get moved to the new components in bug 1484886 before you graveyarded them?
Flags: needinfo?(dkl)
(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #4)
> Bug 1484886 needs to be resolved before this can happen. 
> 
> Did the open bugs in the above components get moved to the new components in
> bug 1484886 before you graveyarded them?

Sorry I would bet probably not. For simple minded people like myself, please mention that this bug is not ready to go in the initial comment in the future. I did not easily see that there was a blocker bug attached to this.

dkl
Flags: needinfo?(dkl)
Do we need to do any kind of rollback or can this be fixed easily?
Are there any bugs in the three components which where graveyarded that need to be moved?
Flags: needinfo?(cam)
Yes, all the bugs in those components should be moved into the components mentioned in bug 1484886 comment 0.
Flags: needinfo?(cam)
Could you make the moves mentioned in the comment above?
Flags: needinfo?(dkl)
Oh, hang on, why is "Layout: Images" in Graveyard?  The three components whose bugs were to be moved into other components, and then graveyarded, were:

Layout: HTML Frames (bugs in this component to be moved into Layout: Images)
Layout: Misc Code (bugs in this component to be moved into Layout)
Layout: View Rendering (bugs in this component to be moved into Layout: Web Painting)

But I see that Core Graveyard contains "Layout: Images" but not "Layout: View Rendering".
Has "Core :: Layout: R & A Pos" disappeared as part of this change?
It’s now Layout: Positioned as per Bug 1484408.
I'm reopening this because this move was done before bugs needed to be moved across components.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Cameron McCormack (:heycam) from comment #10)
> Oh, hang on, why is "Layout: Images" in Graveyard?  The three components
> whose bugs were to be moved into other components, and then graveyarded,
> were:
> 
> Layout: HTML Frames (bugs in this component to be moved into Layout: Images)
> Layout: Misc Code (bugs in this component to be moved into Layout)
> Layout: View Rendering (bugs in this component to be moved into Layout: Web
> Painting)
> 
> But I see that Core Graveyard contains "Layout: Images" but not "Layout:
> View Rendering".

Ok it seems that was my mistake. I moved Layout: HTML Frames and Layout: Misc Code to Graveyard. But somehow (must have been a senior moment) I moved Layout: Images by mistake instead of Layout: View Rendering.

It is not a huge issue in that I can reverse the move to put it back as long as noone created a new Layout: Images component which seems to not have happened.

So if you want I can
1) Move Layout: Images back to Core
2) Move Layout: HTML Frames bugs to Layout: Images afterwards
3) Move Layout: Misc Code bugs into Core :: Layout
4) and Move Layout: View Rendering bugs into Core :: Layout: Web Painting.

Will this get us to where we need to be?

dkl
Flags: needinfo?(ehumphries)
Flags: needinfo?(dkl)
Flags: needinfo?(cam)
Please do that.
Flags: needinfo?(ehumphries)
Flags: needinfo?(dkl)
Flags: needinfo?(cam)
> 1) Move Layout: Images back to Core

Done

> 2) Move Layout: HTML Frames bugs to Layout: Images afterwards

Done

> 3) Move Layout: Misc Code bugs into Core :: Layout

Done

> 4) and Move Layout: View Rendering bugs into Core :: Layout: Web Painting.

and Done.

Should this be closed?
Flags: needinfo?(dkl)
Thanks, I think everything is done.  I cannot see "Layout: Misc Code", "Layout: View Rendering", or "Layout: HTML Frames" when I browse https://bugzilla.mozilla.org/describecomponents.cgi?product=Core%20Graveyard but I think that's by design?
I'd like to keep this bug open. The BMO team is working on another deadline this week and then they can review the moves the need to complete.
emma, is this bug ready to close now?
Flags: needinfo?(ehumphries)
OK Reopen if more action is needed.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.