Closed Bug 1484901 Opened 3 years ago Closed 3 years ago
Intermittent tier2 test-verify /web-animations/timing-model/animations/playing-an-animation
.html | Resuming an animation from paused calculates start time from hold time - assert _less _than _equal
46 bytes, text/x-phabricator-request
|Details | Review|
> expected a number less than or equal to -49824.299358000004 but got -49824.299358 Some sort of floating point error :/
A few notes: * test-verify only runs when the test is changed, so it might not be intermittent * the float difference looks a lot like float vs. double accuracy, as though something was a float, then got converted to a double, and some calculations on the double then weren't completely accurate
This test appears to occasionally fail. The suspected cause is a combination of: * timer clamping (due to vsync) resulting in the current timeline time after resuming playback and the "ready time" being equal * difference in floating-point precision used in calculating the two measures -- one calculation done in JS and one done using the UA's internal representation of times. Therefore this patch adds the standard tolerance for comparing time values to this comparison.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 9002678 [details] Bug 1484901 - Add tolerance for time comparison in playing-an-animation.html; r?hiro Hiroyuki Ikezoe (:hiro) has approved the revision.
Attachment #9002678 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/58b3e7272104 Add tolerance for time comparison in playing-an-animation.html; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12608 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.