1484901 - Intermittent tier2 test-verify /web-animations/timing-model/animations/playing-an-animation.html | Resuming an animation from paused calculates start time from hold time - assert_less_than_equal

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=195000089&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/JypQNJ4vR-OKX6SaWoT-UQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Brian Birtles (:birtles)]

> expected a number less than or equal to -49824.299358000004 but got -49824.299358

Some sort of floating point error :/

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

A few notes:
 * test-verify only runs when the test is changed, so it might not be intermittent
 * the float difference looks a lot like float vs. double accuracy, as though something was a float, then got converted to a double, and some calculations on the double then weren't completely accurate

Comment 3

[Brian Birtles (:birtles)]

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #2)
> A few notes:
>  * test-verify only runs when the test is changed, so it might not be
> intermittent

Yeah, I ran test-verify on OSX 10.10 before landing this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b81a22882fbec848257f380114b7b55db05af1b5 so hopefully it's not permafail, but given how soon this failed after adding the test in question, I expect it will be high frequency.

>  * the float difference looks a lot like float vs. double accuracy, as
> though something was a float, then got converted to a double, and some
> calculations on the double then weren't completely accurate

We do one calculation using JavaScript Numbers and one using TimeDurations (64-bit integers whose units vary by platform). Normally though that shouldn't be a problem because this is a <= check where we expect it to be significantly less. In the failure case, though, I wonder if we're hitting a combination of vsync timer clamping (which is where the times can end up being equal) and this precision difference.

I'll probably just add some epilson to this check later today.

Comment 4

[Brian Birtles (:birtles)]

Attachment: Bug 1484901 - Add tolerance for time comparison in playing-an-animation.html; r?hiro

This test appears to occasionally fail. The suspected cause is a combination of:

* timer clamping (due to vsync) resulting in the current timeline time after
  resuming playback and the "ready time" being equal
* difference in floating-point precision used in calculating the two measures --
  one calculation done in JS and one done using the UA's internal representation
  of times.

Therefore this patch adds the standard tolerance for comparing time values to
this comparison.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9002678 [details]
Bug 1484901 - Add tolerance for time comparison in playing-an-animation.html; r?hiro

Hiroyuki Ikezoe (:hiro) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58b3e7272104
Add tolerance for time comparison in playing-an-animation.html; r=hiro

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12608 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/58b3e7272104

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 11

[Intermittent Failures Robot]

4 failures in 2568 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 3
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 1
* windows10-64: 1
* osx-10-10: 1
* windows7-32-msvc: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1484901&startday=2018-08-20&endday=2018-08-26&tree=all