Closed Bug 1484904 Opened 3 years ago Closed 3 years ago

Remove unneeded "fill" value in Content Blocking animation

Categories

(Firefox :: Theme, enhancement, P5)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: johannh, Assigned: ctsalinas808, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

bug-1484904.patch
1.32 KB, patch
johannh
: review+
Details | Diff | Splinter Review 
In browser/themes/shared/identity-block/identity-block.inc.css, we can remove the "fill" values in the 50% blocks of the Content Blocking shield CSS animations (one for ltr and one for rtl), here: https://hg.mozilla.org/mozilla-central/rev/8aa36c4082b2#l1.25
Hi, can I have this assigned to me? I'd like to work on this.
Attached patch identity-block.inc.css (obsolete) — — Splinter Review 
Please let me know if I need to make any changes.
Attachment #9003015 - Flags: review?(jhofmann)
(In reply to Christian Salinas from comment #2)
> Created attachment 9003015 [details] [diff] [review]
> identity-block.inc.css
> 
> Please let me know if I need to make any changes.

Hi Christian,

thank you for working on this. You attached the entire changed file, while we need a mercurial patch of your change (if you have mercurial set up you might just need to do "hg commit"). You can read more about this here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_Get_your_code_reviewed

Feel free to ask for help on IRC (https://wiki.mozilla.org/IRC), either in the #introduction channel or ping me directly (my nick is johannh).

Thanks!
Assignee: nobody → ctsalinas808
Status: NEW → ASSIGNED
Attachment #9003015 - Flags: review?(jhofmann)
Got it in a patch file now. Let me know if I need to make other changes.
Attachment #9003261 - Flags: review?(jhofmann)
Comment on attachment 9003261 [details] [diff] [review]
bug-1484904.patch

Review of attachment 9003261 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thank you!

I'll set the checkin-needed flag for you, to get this landed.

Let me know if you're looking for other things to work on. :)
Attachment #9003261 - Flags: review?(jhofmann) → review+
Keywords: checkin-needed
Attachment #9003015 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b085baa475c1
Remove unneeded "fill" value in Content Blocking animation. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b085baa475c1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.