1484904 - Remove unneeded "fill" value in Content Blocking animation

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

In browser/themes/shared/identity-block/identity-block.inc.css, we can remove the "fill" values in the 50% blocks of the Content Blocking shield CSS animations (one for ltr and one for rtl), here: https://hg.mozilla.org/mozilla-central/rev/8aa36c4082b2#l1.25

Comment 1

[Christian Salinas]

Hi, can I have this assigned to me? I'd like to work on this.

Comment 2

[Christian Salinas]

Attachment: identity-block.inc.css

Please let me know if I need to make any changes.

Comment 3

[Johann Hofmann [:johannh]]

(In reply to Christian Salinas from comment #2)
> Created attachment 9003015 [details] [diff] [review]
> identity-block.inc.css
> 
> Please let me know if I need to make any changes.

Hi Christian,

thank you for working on this. You attached the entire changed file, while we need a mercurial patch of your change (if you have mercurial set up you might just need to do "hg commit"). You can read more about this here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_Get_your_code_reviewed

Feel free to ask for help on IRC (https://wiki.mozilla.org/IRC), either in the #introduction channel or ping me directly (my nick is johannh).

Thanks!

Comment 4

[Christian Salinas]

Attachment: bug-1484904.patch

Got it in a patch file now. Let me know if I need to make other changes.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9003261 [details] [diff] [review]
bug-1484904.patch

Review of attachment 9003261 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thank you!

I'll set the checkin-needed flag for you, to get this landed.

Let me know if you're looking for other things to work on. :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b085baa475c1
Remove unneeded "fill" value in Content Blocking animation. r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b085baa475c1