In browser/themes/shared/identity-block/identity-block.inc.css, we can remove the "fill" values in the 50% blocks of the Content Blocking shield CSS animations (one for ltr and one for rtl), here: https://hg.mozilla.org/mozilla-central/rev/8aa36c4082b2#l1.25
Hi, can I have this assigned to me? I'd like to work on this.
Please let me know if I need to make any changes.
(In reply to Christian Salinas from comment #2) > Created attachment 9003015 [details] [diff] [review] > identity-block.inc.css > > Please let me know if I need to make any changes. Hi Christian, thank you for working on this. You attached the entire changed file, while we need a mercurial patch of your change (if you have mercurial set up you might just need to do "hg commit"). You can read more about this here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_Get_your_code_reviewed Feel free to ask for help on IRC (https://wiki.mozilla.org/IRC), either in the #introduction channel or ping me directly (my nick is johannh). Thanks!
Assignee: nobody → ctsalinas808
Status: NEW → ASSIGNED
Got it in a patch file now. Let me know if I need to make other changes.
Attachment #9003261 - Flags: review?(jhofmann)
Comment on attachment 9003261 [details] [diff] [review] bug-1484904.patch Review of attachment 9003261 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thank you! I'll set the checkin-needed flag for you, to get this landed. Let me know if you're looking for other things to work on. :)
Attachment #9003261 - Flags: review?(jhofmann) → review+
Attachment #9003015 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b085baa475c1 Remove unneeded "fill" value in Content Blocking animation. r=johannh
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.