Closed Bug 1484911 Opened Last year Closed Last year

Convert .disabled selectors on <form> elements in extension.css to :disabled

Categories

(WebExtensions :: Frontend, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

This is a follow-up from bug 1484501.

As Blake points out[1] we should probably just convert all the '.disabled' selectors in extension.css to ':disabled', or at least those that clearly apply to form elements. If authors are setting the 'disabled' class on a form element but not also making the form element itself disabled, they're doing it wrong.

[1] https://phabricator.services.mozilla.com/D3743#80367
This does _not_ convert .disabled selectors on non-<form> elements such as
panel-list-items since presumably in such cases the 'disabled' class is being
used to grey-out a whole chunk of content.

For form elements, however, authors shouldn't be greying out elements with the
'disabled' class without also actually making the form element itself disabled
(e.g. with the disabled attribute).
Did a fairly broad try push on this just because I have no idea if any tests actually depend on this or not:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=401a5df635e98027517dd0a089fbab5e05ef56cf

(Not that this push is based on autoland so there could be all sorts of unrelated failure in there.)
Comment on attachment 9002667 [details]
Bug 1484911 - Convert .disabled selectors on <form> elements in extension.css to :disabled; r=bwinton

Blake Winton (:bwinton) (:☕️) has approved the revision.
Attachment #9002667 - Flags: review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3de1d6228039
Convert .disabled selectors on <form> elements in extension.css to :disabled; r=bwinton
https://hg.mozilla.org/mozilla-central/rev/3de1d6228039
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(bbirtles)
I'm afraid I don't have any extensions available for verifying this (in my own extension I worked around this issue).
Flags: needinfo?(bbirtles) → qe-verify-
You need to log in before you can comment on or make changes to this bug.