Closed Bug 1484921 Opened Last year Closed Last year

[Wayland] Delay commit to hidden surfaces

Categories

(Core :: Widget: Gtk, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Recently we're missing some windows with this error:
WARNING: WindowSurfaceWayland::Commit(): parent wl_surface is already hidden/deleted.

When a new window is created and it's not shown/mapped yet we can't commit to such window as Wayland refuses so which results to missing popup/tooltip windows.

We need to delay the commit until the surface is visible.
WindowSurfaceWayland::Commit() request may be called before associated GdkWindow is fully mapped.
In that case the commit fails because we can't commit to hidden wl_surface.

This patch delays the commit until the GdkWindow is fully visible and associated wl_surface
is ready.
This is a regression from Bug 1444437.
Keywords: regression
Blocks: 1487763
Comment on attachment 9003059 [details]
Bug 1484921 - [Wayland] Delay commit to hidden surfaces, r=jhorak

Jan Horak [:jhorak] has approved the revision.
Attachment #9003059 - Flags: review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cdd5c9a9bc4
[Wayland] Delay commit to hidden surfaces, r=jhorak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5cdd5c9a9bc4
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Does this need a Beta approval request for 63 or can it ride 64 to release?
Blocks: 1444437
Flags: needinfo?(stransky)
Would be great to have at 63 as it's regressed there.
Flags: needinfo?(stransky)
Comment on attachment 9003059 [details]
Bug 1484921 - [Wayland] Delay commit to hidden surfaces, r=jhorak

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1444437
[User impact if declined]: Invisible popup windows (tooltips/menu) on Wayland.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It's not built in mozilla builds, used by distros only.
[String changes made/needed]: none
Attachment #9003059 - Flags: approval-mozilla-beta?
Comment on attachment 9003059 [details]
Bug 1484921 - [Wayland] Delay commit to hidden surfaces, r=jhorak

No risk as Mozilla  doen't ship a Wayland Firefox, distro only, approved for 63 beta 4
Attachment #9003059 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.