Closed Bug 1484925 Opened 2 years ago Closed 2 years ago
Counter documentation links to non-existing file
Currently the Use Counter documentation links to a file called `nsCSSPropList.h`. However this file does not exist anymore. I think the generated `ServoCSSPropList.h` is its replacement (however, that file is not available in searchfox or dxr) We should fix the link. : https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/use-counters.html#css-properties : https://dxr.mozilla.org/mozilla-central/source/layout/style/nsCSSPropList.h
Whiteboard: [good first bug][lang=rst]
Priority: -- → P3
ServoCSSPropList.h is available here: https://searchfox.org/mozilla-central/source/__GENERATED__/layout/style/ServoCSSPropList.h :emilio: Is that the best file to link to from the documentation?
Yeah, that one should work. Thanks!
Is it open for grab? I am interested to take this up.
Yes, I just assigned the bug to you. The task is rather simple: Exchange the link in the use counter documentation with the above link to the ServoCSSPropList.h file. Once you've done that, compile the documentation with `./mach doc`, open it in a browser, go to the Use Counter documentation and check that the link works and everything is correct. : https://searchfox.org/mozilla-central/rev/e126996d9b0a3d7653de205898517f4f5b632e7f/toolkit/components/telemetry/docs/collection/use-counters.rst#52 Please ping me if you need any additional help.
Assignee: nobody → arshadkazmi42
Below searchfox url needs to be updated in that? `https://searchfox.org/mozilla-central/source/__GENERATED__/layout/style/ServoCSSPropList.h` Or is there any other production URL which needs to be used?
So. I found a similar type of url for other link. So adding this file and pushing code to Phabricator for review. Let me know if that url is different & needs to be changed
Pushed code to Phabricator. And added you as reviewer https://phabricator.services.mozilla.com/D4363
Comment on attachment 9004317 [details] Bug 1484925 - UseCounter Broken Link Fixed. Jan-Erik Rediger [:janerik] has approved the revision.
Attachment #9004317 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d214235eef08 UseCounter Broken Link Fixed. r=janerik
You need to log in before you can comment on or make changes to this bug.