UseCounter documentation links to non-existing file

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: janerik, Assigned: arshadkazmi42, Mentored)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [good first bug][lang=rst])

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
Currently the Use Counter documentation[1] links to a file called `nsCSSPropList.h`[2].
However this file does not exist anymore.

I think the generated `ServoCSSPropList.h` is its replacement (however, that file is not available in searchfox or dxr)

We should fix the link.


[1]: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/use-counters.html#css-properties
[2]: https://dxr.mozilla.org/mozilla-central/source/layout/style/nsCSSPropList.h
(Reporter)

Updated

7 months ago
Mentor: jrediger
Whiteboard: [good first bug][lang=rst]
(Reporter)

Updated

7 months ago
Priority: -- → P3
(Reporter)

Comment 1

7 months ago
ServoCSSPropList.h is available here: https://searchfox.org/mozilla-central/source/__GENERATED__/layout/style/ServoCSSPropList.h

:emilio: Is that the best file to link to from the documentation?
Flags: needinfo?(emilio)
Yeah, that one should work. Thanks!
Flags: needinfo?(emilio)
(Assignee)

Comment 3

7 months ago
Is it open for grab? I am interested to take this up.
Flags: needinfo?(jrediger)
(Reporter)

Comment 4

7 months ago
Yes, I just assigned the bug to you.

The task is rather simple:
Exchange the link in the use counter documentation[1]  with the above link to the ServoCSSPropList.h file.

Once you've done that, compile the documentation with `./mach doc`, open it in a browser, go to the Use Counter documentation and check that the link works and everything is correct.

[1]: https://searchfox.org/mozilla-central/rev/e126996d9b0a3d7653de205898517f4f5b632e7f/toolkit/components/telemetry/docs/collection/use-counters.rst#52

Please ping me if you need any additional help.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(jrediger)
(Assignee)

Comment 5

7 months ago
Below searchfox url needs to be updated in that?

`https://searchfox.org/mozilla-central/source/__GENERATED__/layout/style/ServoCSSPropList.h`

Or is there any other production URL which needs to be used?
Flags: needinfo?(jrediger)
(Assignee)

Comment 6

7 months ago
So. I found a similar type of url for other link. So adding this file and pushing code to Phabricator for review.

Let me know if that url is different & needs to be changed
(Assignee)

Comment 8

7 months ago
Pushed code to Phabricator. And added you as reviewer

https://phabricator.services.mozilla.com/D4363
(Reporter)

Updated

7 months ago
Flags: needinfo?(jrediger)
(Reporter)

Comment 9

7 months ago
Comment on attachment 9004317 [details]
Bug 1484925 - UseCounter Broken Link Fixed.

Jan-Erik Rediger [:janerik] has approved the revision.
Attachment #9004317 - Flags: review+

Comment 10

7 months ago
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d214235eef08
UseCounter Broken Link Fixed. r=janerik

Comment 11

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d214235eef08
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.