Closed Bug 1484941 Opened Last year Closed Last year

Change timeout and script timeout error HTTP codes from 408 to 500

Categories

(Testing :: geckodriver, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

Issue: https://github.com/w3c/webdriver/issues/1287
Spec change: https://github.com/w3c/webdriver/pull/1292

This bug will track changes to WPT tests, the webdriver crate, and
geckodriver.  The spec change cannot land until we have tests ready.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Whilst it is logically correct to use 408 for the
ErrorStatus::ScriptTimeout and ::Timeout errors, it
causes a collision with HTTP semantics implement in HTTP clients.
To support Keep-Alive we allow retries in HTTP clients and if a
client sees code 408 it thinks that the server has gone away and
retries the request.

This causes WebDriverCommand::ExecuteScript, ::Get, and ::Refresh
commands to be sent twice with some HTTP clients.

This is a backwards incompatible change to WebDriver in order to
not break HTTP/1.1 Keep-Alive.
Attachment #9002753 - Flags: review?(hskupin)
Comment on attachment 9002753 [details] [diff] [review]
Change ErrorStatus::{ScriptTimeout,Timeout} HTTP codes from 408 to 500.

Review of attachment 9002753 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. But could you please wait with landing this patch until my Serde patch landed? Otherwise it will cause merge conflicts for me again. Thanks!
Attachment #9002753 - Flags: review?(hskupin) → review+
Yes, was going to hold off.
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72a737dd8639
Change ErrorStatus::{ScriptTimeout,Timeout} HTTP codes from 408 to 500. r=whimboo
As expected there were no conflicts during rebase here.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12641 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/72a737dd8639
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.