1484972 - Update Debugger Frontend v84

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-83...release-84

Comment 1

[Jason Laster [:jlast]]

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=13bdf34ce8cb05805577a5802e253c485cd6cd14
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92c34bbfa3c4a2a9b170d0d645e28654e1d4977e

Comment 2

[Jason Laster [:jlast]]

Attachment: 84-1.patch

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34d532bcd52936de1b0a639adcf33bc17de15877
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4f7e763619abe2fafae00b6444923688a7997e6

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9003014 [details] [diff] [review]
84-1.patch

Review of attachment 9003014 [details] [diff] [review]:
-----------------------------------------------------------------

Reps look okay to me :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b2f96523b1
Update Debugger Frontend v84. r=dwalsh

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c9b2f96523b1

Comment 7

[Jason Laster [:jlast]]

v83 - https://treeherder.mozilla.org/#/jobs?repo=try&revision=507535665b834f2718a71740c91cf9f092d169ba
v84 - https://treeherder.mozilla.org/#/jobs?repo=try&revision=d48cc392ed02abcae89d23f87ff8b1895e3f813c

v83-1 - https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be1067b04c8dd18c85ba2ed7b38e297546c4af6

Comment 8

[Jason Laster [:jlast]]

v83-2 (revert arai) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3abbe9fa7fa36d23aada2edb9fdfc8567f877301 
v83-3 (revert memoize) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5307abf5be26634e9f4f1bbfcb3bd0758101c67d

Comment 9

[Jason Laster [:jlast]]

86 (sans memoize) https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=5de8229bfe3fed95067eceb38d73ce6ece0b1617

86 (with memoize / sans selector) https://treeherder.mozilla.org/#/jobs?repo=try&revision=752d4a0b8b2343b5beaa93b8b97d8caf5d442872

86 (straight up) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d085d434c1423b3231903cc62a0377a4e6f8997a

Comment 10

[Jason Laster [:jlast]]

86 without memoize - https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eb544f06b135db1e23cf007d76a98ca25bac27c

Comment 11

[Jason Laster [:jlast]]

86 with the selector (1100ms) -  https://perfht.ml/2ws4vdM
86 without the selector (930ms) -  https://perfht.ml/2PRUI8Y

So i looked into this a bit and found a couple of interesting things:
1. the total JS run-time difference is very small (710/680ms) 
2. the selector does its job and prevents lots of spurious react renders / codemirror calls
3. the longer run had more C++ run time, i'm not sure where that came from...