Update Debugger Frontend v84

RESOLVED FIXED in Firefox 63

Status

enhancement
P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jlast, Assigned: jlast)

Tracking

unspecified
Firefox 63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Posted patch 84-1.patchSplinter Review
Attachment #9003014 - Flags: review?(dwalsh)
Comment on attachment 9003014 [details] [diff] [review]
84-1.patch

Review of attachment 9003014 [details] [diff] [review]:
-----------------------------------------------------------------

Reps look okay to me :)
Attachment #9003014 - Flags: review?(dwalsh) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b2f96523b1
Update Debugger Frontend v84. r=dwalsh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c9b2f96523b1
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
86 with the selector (1100ms) -  https://perfht.ml/2ws4vdM
86 without the selector (930ms) -  https://perfht.ml/2PRUI8Y

So i looked into this a bit and found a couple of interesting things:
1. the total JS run-time difference is very small (710/680ms) 
2. the selector does its job and prevents lots of spurious react renders / codemirror calls
3. the longer run had more C++ run time, i'm not sure where that came from...
You need to log in before you can comment on or make changes to this bug.