Avoid writing past the logical length of a string in XPCOM

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Don't use BeginWriting() to write past the logical length of a string in XPCOM. See bug 1484668 for details.
(Assignee)

Comment 1

6 months ago
Created attachment 9002752 [details]
Bug 1484987 - Avoid writing past the logical length of a string in XPCOM.

MozReview-Commit-ID: 3qkhOiQduLQ
Comment on attachment 9002752 [details]
Bug 1484987 - Avoid writing past the logical length of a string in XPCOM.

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9002752 - Flags: review+

Comment 3

6 months ago
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9216e8942ed6
Avoid writing past the logical length of a string in XPCOM. r=froydnj

Comment 5

6 months ago
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/097c92352197
Avoid writing past the logical length of a string in XPCOM. r=froydnj
(Assignee)

Updated

6 months ago
Flags: needinfo?(hsivonen)
(Assignee)

Comment 7

6 months ago
Sorry about forgetting to check gtest. Reopened review with fixes.
Flags: needinfo?(hsivonen)

Comment 10

6 months ago
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e59897303384
Avoid writing past the logical length of a string in XPCOM. r=froydnj

Comment 11

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e59897303384
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.