Closed Bug 1484987 Opened 2 years ago Closed 2 years ago

Avoid writing past the logical length of a string in XPCOM

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Don't use BeginWriting() to write past the logical length of a string in XPCOM. See bug 1484668 for details.
MozReview-Commit-ID: 3qkhOiQduLQ
Comment on attachment 9002752 [details]
Bug 1484987 - Avoid writing past the logical length of a string in XPCOM.

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9002752 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9216e8942ed6
Avoid writing past the logical length of a string in XPCOM. r=froydnj
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/097c92352197
Avoid writing past the logical length of a string in XPCOM. r=froydnj
Flags: needinfo?(hsivonen)
Sorry about forgetting to check gtest. Reopened review with fixes.
Flags: needinfo?(hsivonen)
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e59897303384
Avoid writing past the logical length of a string in XPCOM. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/e59897303384
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.