Closed
Bug 1484987
Opened 6 years ago
Closed 6 years ago
Avoid writing past the logical length of a string in XPCOM
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
Don't use BeginWriting() to write past the logical length of a string in XPCOM. See bug 1484668 for details.
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 3qkhOiQduLQ
Comment 2•6 years ago
|
||
Comment on attachment 9002752 [details] Bug 1484987 - Avoid writing past the logical length of a string in XPCOM. Nathan Froyd [:froydnj] has approved the revision.
Attachment #9002752 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9216e8942ed6 Avoid writing past the logical length of a string in XPCOM. r=froydnj
Comment 4•6 years ago
|
||
Backed out for build bustages at builds/worker/workspace/build/src/xpcom/io/nsStorageStream.cpp Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9216e8942ed6d31b68411623420e45f3ca964adf Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196363516&repo=autoland&lineNumber=11679 Backout: https://hg.mozilla.org/integration/autoland/rev/14e5c98875ec7b56d847f74f4eb1658683126310
Flags: needinfo?(hsivonen)
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/097c92352197 Avoid writing past the logical length of a string in XPCOM. r=froydnj
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(hsivonen)
Comment 6•6 years ago
|
||
Backed out for failing gtest at Base64.TruncateOnInvalidDecodeCString Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=097c9235219784158e5d634c4e9e96c54bc7d8fc Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196371977&repo=autoland&lineNumber=1196 Backout: https://hg.mozilla.org/integration/autoland/rev/b4115d7d4f642978f0301479f0af455d2e1c989c
Flags: needinfo?(hsivonen)
Assignee | ||
Comment 7•6 years ago
|
||
Sorry about forgetting to check gtest. Reopened review with fixes.
Flags: needinfo?(hsivonen)
Assignee | ||
Comment 8•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a76a687402945801d44787930071646fb19f8db
Assignee | ||
Comment 9•6 years ago
|
||
Another try run without other patches interfering: https://treeherder.mozilla.org/#/jobs?repo=try&revision=017bbc267a61f62ea3d89f047cae14943bda55d2
Comment 10•6 years ago
|
||
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e59897303384 Avoid writing past the logical length of a string in XPCOM. r=froydnj
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e59897303384
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•