1484994 - Undo close tabs not working in Private Browsing with "Close Private Tabs" enabled

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Simon Basca [:SimonB]]

Build: 13.1()
Device: iPhone 8
iOS: 11.4

Pre-conditions;
- Enable "Close Private tabs" from settings

Steps to reproduce: 
1. Open a tab in Private Browsing
2. Open Tabs Tray
3. Tap "Close all tabs"
4. Tap "Undo"

Actual results:
- Undo close tabs not working in Private Browsing when "Close Private Tabs" is enabled.

Comment 1

[Simon Basca [:SimonB]]

First bad build is 13.0 (11477).

Comment 2

[:garvan]

PR https://github.com/mozilla-mobile/firefox-ios/pull/4160

I propose disabling undo on private tabs. 
My comment on the bug:
"This feature seems counter intuitive, that a private tab (thus highly ephemeral) is kept in some form of storage for undo.
I acknowledge that as an advanced user I realize the storage is temporary memory."

Comment 3

[:garvan]

landed on master. No more undo of 'close all private tabs' due to this feature being inconsistent with non-persistent nature of private tabs, and the option to undo closing the tabs might give the impression to the user the private tabs are persisted after closing.