Closed Bug 1485022 Opened Last year Closed Last year
Stop using gcli for paint flashing
46 bytes, text/x-phabricator-request
|Details | Review|
As alex mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1447490 A bunch of optional toolbox buttons are currently relying on gcli commands, whereas they could use regular actors to do that: * Paintflashing https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#514 The real code that toggle the paint flashing, that should be moved to an actor is here: https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/paintflashing.js#46-78 this can be moved to its own actor
Set the targets paintflashing via the reconfigure on the target.
Summary: Move Paintflash to own actor → Stop using gcli for paint flashing
Comment on attachment 9002799 [details] Bug 1485022 - use target.reconfigure to set paint flashing; r=ochameau Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9002799 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ea662eb5edee use target.reconfigure to set paint flashing; r=ochameau
You need to log in before you can comment on or make changes to this bug.