Closed
Bug 1485022
Opened 6 years ago
Closed 6 years ago
Stop using gcli for paint flashing
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
As alex mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1447490 A bunch of optional toolbox buttons are currently relying on gcli commands, whereas they could use regular actors to do that: * Paintflashing https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#514 The real code that toggle the paint flashing, that should be moved to an actor is here: https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/paintflashing.js#46-78 this can be moved to its own actor
|
Assignee | |
Comment 1•6 years ago
|
||
Set the targets paintflashing via the reconfigure on the target.
|
|
Assignee | |
Updated•6 years ago
|
Summary: Move Paintflash to own actor → Stop using gcli for paint flashing
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9002799 [details] Bug 1485022 - use target.reconfigure to set paint flashing; r=ochameau Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9002799 -
Flags: review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92da281dab0a3b4a5fae422525c446fb47dbd2f5
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea662eb5edee use target.reconfigure to set paint flashing; r=ochameau
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ea662eb5edee
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•