Open Bug 1485026 Opened 6 years ago Updated 2 years ago

Remove nsTSubstring::GetMutableData

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement

Tracking

()

People

(Reporter: hsivonen, Unassigned)

References

Details

nsTSubstring::GetMutableData has very few callers.

Infallible case:
https://searchfox.org/mozilla-central/search?q=symbol:_ZN12nsTSubstring14GetMutableDataEPPN7mozilla6detail13nsTStringReprIT_E9char_typeENS4_9size_typeE&redirect=false

Fallible case:
https://searchfox.org/mozilla-central/search?q=symbol:_ZN12nsTSubstring14GetMutableDataEPPN7mozilla6detail13nsTStringReprIT_E9char_typeENS4_9size_typeERKNS4_10fallible_tE&redirect=false

It seems that most of these uses would be cleaner using BeginWriting() and the ones that adjust the length could use the (more versatile) BulkWrite API from bug 1482828.
Depends on: 1485289
Depends on: 1485319
Depends on: 1485320
Depends on: 1485325
Component: String → XPCOM
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.