Closed Bug 1485029 Opened Last year Closed Last year

Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp

Categories

(Core :: DOM: File, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(1 file)

I happened to notice that PopulateBufferForBinaryString() in FileReader.cpp performs an operation that we have SIMD acceleration for, so let's use SIMD acceleration.
Once bug 1449849 is fixed, this code shouldn't expand the data to UTF-16 at all.
Comment on attachment 9002777 [details]
Bug 1485029 - Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp.

Olli Pettay [:smaug] has approved the revision.
Attachment #9002777 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06caf48cb3b5
Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp. r=smaug
https://hg.mozilla.org/mozilla-central/rev/06caf48cb3b5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.