Closed Bug 1485039 Opened 6 years ago Closed 6 years ago

Lightning icon missing in preferences

Categories

(Calendar :: Preferences, enhancement)

Lightning 6.2
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
6.2.2.1

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1446748 removed the packaging of the cal-icon32.png on Linux and Windows. With backporting to ESR60 this is now missing for the preferences in dialog.
Attached patch LigthningPrefsIcon.patch — — Splinter Review
This patch is for ESR and beta only. C-c has no prefs in dialog.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9002792 - Flags: review?(philipp)
Attachment #9002792 - Flags: approval-calendar-esr?(philipp)
Attachment #9002792 - Flags: approval-calendar-beta?(philipp)
Comment on attachment 9002792 [details] [diff] [review]
LigthningPrefsIcon.patch

This is needed quickly for TB 60.0 b11.
Attachment #9002792 - Flags: review?(makemyday)
Comment on attachment 9002792 [details] [diff] [review]
LigthningPrefsIcon.patch

Review of attachment 9002792 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #9002792 - Flags: review?(philipp)
Attachment #9002792 - Flags: review?(makemyday)
Attachment #9002792 - Flags: review+
Attachment #9002792 - Flags: approval-calendar-esr?(philipp)
Attachment #9002792 - Flags: approval-calendar-esr+
Attachment #9002792 - Flags: approval-calendar-beta?(philipp)
Attachment #9002792 - Flags: approval-calendar-beta+
TB 60.0 beta 11: https://hg.mozilla.org/releases/comm-beta/rev/8fd10c8015b96dec8d7f719c92a8d230cd29460e (BETA_60_CONTINUATION)
TB 60.1 ESR: https://hg.mozilla.org/releases/comm-esr60/rev/9d4281b4939e379afb53c490a729fa03eeb77b8f

Luckily the sheriff noticed the copy/paste error in the patch that neither the reviewer nor the approver had spotted :-(
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 6.2
Version: unspecified → Lightning 6.2
Target Milestone: 6.2 → 6.2.1
Target Milestone: 6.2.1 → 6.2.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: