Closed Bug 1485061 Opened 7 years ago Closed 7 years ago

fix BetaVersionRule to work with products with no build/version data

Categories

(Socorro :: Processor, task, P2)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: willkg, Assigned: willkg)

Details

The processor has a BetaVersionRule that stomps on the processed_crash "version" field with the "correct version" if the release channel is "beta" or "aurora". It determines the "correct version" by looking at the product_versions table matching on product_name, release_version, and build_id. The problem here is that if the (product, version, build_id) doesn't exist in the product_versions table, then the version becomes MAJOR.0b0 regardless of what the crash report had in it. (Incidentally, this rule is messing up the "dev edition" builds currently resulting in the AuroraVersionFixitRule. bug #1418037) New products may or may not have build/version information in the product_versions table, so incoming crashes are getting their version changed to MAJOR.0b0. This bug covers figuring out how to fix the BetaVersionRule to account for these two scenarios and then fixing it.
Grabbing this to do soon. There's a related bug for rewriting BetaVersionRule to use an API in the webapp. Maybe that's worth tackling here, too.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Priority: -- → P2
You can see this manifest itself with the Focus crashes. This crash report has Version 62.0 in the raw crash and that was changed by the BetaVersionRule to 62.0b0 in the processed crash: https://crash-stats.mozilla.com/report/index/b2cd19a5-5c3b-4464-9f17-932830180821
I'm marking this WONTFIX. Here's why: The incoming crash report for beta versions has MAJOR.0 type versions--there's no indication of the beta version (e.g. b7) in the version. The BetaVersionRule adds that if we can find build information for that (product, version, build) combination. The build information is external--it's not available in the crash report. Adding a b0 to the end of the version is the right thing to do here. If products for which we have no build information need something different, they'd need to provide us build information. We can't infer it from the crash report. Given that, there's nothing we can do here for products for which we have no build information. Regarding the AuroraVersionFixitRule--that's a problem we need to solve elsewhere. I thought we had a bug for that, but couldn't find it so I wrote up bug #1486035 to cover it.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.