1485083 - Consider blocking @testpilot-addon < 3.0.0

Status: VERIFIED FIXED

(Toolkit :: Blocklist Policy Requests, enhancement)

Description

[Wil Clouser [:clouserw]]

With version 3.0.0 (released in April of 2018) Test Pilot became a Web Extension.  We upgrade normally and have had several subsequent versions (currently on version 3.0.4vffdc510).

Bug 1483641 reports some people on versions of Test Pilot <3.0.0 are having problems upgrading due to a shutdown crash.  This bug is to decide if it's happening enough to soft block old versions of Test Pilot and if so, to add it to the blocklist.

ID:   @testpilot-addon
Version:  <3.0.0

Comment 1

[Kris Maglione [:kmag]]

Note that "shutdown crash" doesn't quite describe the problem. The root issue is that we block browser shutdown on extension shutdown, and we block extension shutdown on extension startup. And old versions of Test Pilot appear to return a promise from their startup methods which never resolves.

This blocks not only browser shutdown, but also regular extension shutdown. Which, in turn, blocks ordinary extension upgrades. The only way for affected users to upgrade is to disable the extension and restart the browser before attempting to upgrade. A soft block has the same effect, and should fix both the shutdown hangs and the broken upgrades.

Comment 2

[Andreas Wagner [:TheOne] [use NI]]

I will take care of this once bug 1485310 is resolved.

Comment 3

[Andreas Wagner [:TheOne] [use NI]]

Wil, what is the latest version before 3.0.0?

Comment 4

[Wil Clouser [:clouserw]]

Thanks for the explanation, Kris.  Blocking this sounds like a good idea then.

Andreas, the version before 3.0.0 was 2.0.8-dev-259fe19

Comment 5

[Andreas Wagner [:TheOne] [use NI]]

The block has been staged. Philipp, can you please review and push?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Done

Comment 7

[Wil Clouser [:clouserw]]

We confirmed that someone with <3.0.0 got prompted, restarted, and it upgraded successfully.  Thanks.