Closed Bug 1485115 Opened Last year Closed Last year

Format the React and Redux components in the Box Model and Grid Inspector

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

We are doing a bit of formatting and reformatting in this patch:

- Sort the propTypes and this.props alphabetically
- Formatting how we return React DOM. 
We typically do:
return dom.div(
  {
     ...
  }
);  
I am introducing braces after the return so that we can correctly indent the React DOM:
return (
  dom.div()
);
- Also another formatting for React DOM. If we only have a single prop for the React component, I am formatting it to be on the same name if possible.
Example: 
dom.span(
  {
    id: "blah"
  }
) 
To: 
dom.span({ id: "blah" })
Attached patch 1485115.patchSplinter Review
Attachment #9002881 - Flags: review?(rcaliman)
Attachment #9002881 - Flags: review?(rcaliman) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7a5715e699
Format the React and Redux components in the Box Model and Grid Inspector. r=rcaliman
https://hg.mozilla.org/mozilla-central/rev/3b7a5715e699
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Depends on: 1493937
You need to log in before you can comment on or make changes to this bug.