Closed Bug 1485118 Opened 2 years ago Closed 2 years ago

Format the React and Redux components in RDM

Categories

(DevTools :: Responsive Design Mode, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

We are doing a bit of formatting and reformatting in this patch:

- Sort the propTypes and this.props alphabetically
- Formatting how we return React DOM. 
We typically do:
return dom.div(
  {
     ...
  }
);  
I am introducing braces after the return so that we can correctly indent the React DOM:
return (
  dom.div()
);
- Also another formatting for React DOM. If we only have a single prop for the React component, I am formatting it to be on the same name if possible.
Example: 
dom.span(
  {
    id: "blah"
  }
) 
To: 
dom.span({ id: "blah" })
Attachment #9002888 - Flags: review?(rcaliman)
Attachment #9002888 - Flags: review?(rcaliman) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af1af69c1d9c
Format the React and Redux components in RDM. r=rcaliman
https://hg.mozilla.org/mozilla-central/rev/af1af69c1d9c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.