1485119 - Assertion failure: JS::StringIsASCII(message.get()) with parseBin shell function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
parseBin(new ArrayBuffer(0), {format: "\u{101}"})
---

Asserts with:
---
Assertion failure: JS::StringIsASCII(message.get()), at /home/andre/git/mozilla-central/js/src/vm/JSContext.cpp:413
---

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Don't pass the result of ValueToPrintableUTF8 to a function called JS_ReportErrorASCII

I imagine I'm racing you to land this, now that I see what's buggy.  Oh well.

Comment 2

[André Bargull [:anba]]

Comment on attachment 9002946 [details] [diff] [review]
Don't pass the result of ValueToPrintableUTF8 to a function called JS_ReportErrorASCII

Review of attachment 9002946 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Jeff Walden [:Waldo] from comment #1)
> I imagine I'm racing you to land this, now that I see what's buggy.  Oh well.

I didn't have immediate plans to work on this bug. The only thing this patch does is that it'll create a small merge conflict with bug 1485066 for me. :-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ad53dbb0ae
Don't pass the result of ValueToPrintableUTF8 to a function called JS_ReportErrorASCII.  r=anba

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/03ad53dbb0ae