Closed
Bug 1485155
Opened 6 years ago
Closed 6 years ago
Treat javadoc warnings as errors
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(geckoview62 wontfix, firefox-esr60 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(2 files)
We have accumulated some javadoc warnings that are being overlooked. We should turn these warnings into errors.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Some common javadoc mistakes are logged as warnings and are being overlooked. javadoc does not support warning-as-error natively, so this patch scans the javadoc output in gradle and makes the task fail if any warnings are detected.
Comment 3•6 years ago
|
||
Comment on attachment 9002937 [details] Bug 1485155 - 2. Treat javadoc warnings as errors; r?nalexander Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9002937 -
Flags: review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/679ac57458c0 1. Fix javadoc warnings; r=jchen https://hg.mozilla.org/integration/mozilla-inbound/rev/34fef84f491b 2. Treat javadoc warnings as errors; r=nalexander
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/679ac57458c0 https://hg.mozilla.org/mozilla-central/rev/34fef84f491b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 6•6 years ago
|
||
We don't need to uplift this fix to GV 62 or 63.
status-firefox62:
--- → wontfix
status-firefox-esr60:
--- → wontfix
status-geckoview62:
--- → wontfix
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 64 → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•