Closed Bug 1485180 Opened 6 years ago Closed 6 years ago

Add telemetry to detect truncated hashes in download protection lookups

Categories

(Toolkit :: Safe Browsing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

Attachments

(2 files)

Google sent us reports of truncated hashes in the application reputation lookups we are doing against their service.

Let's see if we can detect these client-side.
Attachment #9002983 - Flags: review?(chutten)
Comment on attachment 9002983 [details]
bug1485180-data-review-request.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, expires in 69.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Category 1, Technical

    Is the data collection request for default-on or default-off?

default-on

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No (only categorical labels)

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :francois will file a follow-up bug to renew or remove (or maybe it'll take place in the verification bug 1190020, who can say).

---
Result: datareview+
Attachment #9002983 - Flags: review?(chutten) → review+
Comment on attachment 9002981 [details]
Bug 1485180 - Instrument invalid download protection hashes. r?dimi

Dimi Lee[:dimi][:dlee] has approved the revision.
Attachment #9002981 - Flags: review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b58d46fa298f
Instrument invalid download protection hashes. r=dimi
https://hg.mozilla.org/mozilla-central/rev/b58d46fa298f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: