Attendees dialog default size is not high enough, far too wide

RESOLVED FIXED in 6.5

Status

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

Trunk
Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

This is probably fallout from changing to richlistbox.
Attachment #9003044 - Flags: review?(makemyday)
Comment on attachment 9003044 [details] [diff] [review]
1485204-attendees-sizes-1.diff

Review of attachment 9003044 [details] [diff] [review]:
-----------------------------------------------------------------

That doesn't work for me here on Win 10. The dialog height is overwritten when restoring the persited properties from xulstore.json. So you better should operate with a minimum height value here. The same is true for the width of the attendees- list and the freebusy pane. By moving the splitter, I could get the former to 0 width and the latter to 100. and such a setting is persisted when closing and reopening.

When defining minimum values, I would appreaciate to put the definition in the css instead of the xul file.

When reducing the window size to the minimal possible height (for me this is 277) and you try to close the dialog with the ok button, you get an error and the dialog doesn't close:

>TypeError: this.getListItem(...) is undefined[Learn More] calendar-event-dialog-attendees.xml:726:20
> getInputElement      chrome://calendar/content/calendar-event-dialog-attendees.xml:726:20
> get_attendees        chrome://calendar/content/calendar-event-dialog-attendees.xml:296:34
> onAccept             chrome://calendar/content/calendar-event-dialog-attendees.js:123:1
> anonymous            chrome://global/content/bindings/dialog.xml line 404 > Function:3:8
> _fireButtonEvent     chrome://global/content/bindings/dialog.xml:405:28
> _doButtonCommand     chrome://global/content/bindings/dialog.xml:373:28
> _handleButtonCommand chrome://global/content/bindings/dialog.xml:361:18
> editAttendees        chrome://lightning/content/lightning-item-iframe.js:1955:5
> receiveMessage       chrome://lightning/content/lightning-item-iframe.js:190:31

If you enlarge the height a little bit, you could close again.
Attachment #9003044 - Flags: review?(makemyday) → review-
I'm not defining minimum values*, I'm defining initial values. Try opening that dialog in a new profile or with the values removed from xulStore.json.

* at least not with this patch.
Blocks: 1484636
Looking at this dialog again, I notice the datepickers are broken, probably by bug 1474123. So I've fixed them, as well as the won't-close-if-not-tall-enough problem.
Attachment #9003044 - Attachment is obsolete: true
Attachment #9003735 - Flags: review?(richard.marti)
Comment on attachment 9003735 [details] [diff] [review]
1485204-attendees-sizes-2.diff

The additional stylesheets look reasonable. Better MMD does the review as he did already the first patch.
Attachment #9003735 - Flags: review?(richard.marti) → review?(makemyday)
Comment on attachment 9003735 [details] [diff] [review]
1485204-attendees-sizes-2.diff

Review of attachment 9003735 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good. r+ with comment considered.

::: calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
@@ +22,5 @@
>          onload="onLoad()"
>          ondialogaccept="return onAccept();"
>          ondialogcancel="return onCancel();"
>          defaultButton="none"
> +        height="500"

Can you move this definition also to the css file? applies also for the two width definitions you added in this file.
Attachment #9003735 - Flags: review?(makemyday) → review+
I've also moved the padding info from the style attribute into the stylesheet as there's no reason for it to be where it is.
Attachment #9003735 - Attachment is obsolete: true
Attachment #9005512 - Flags: review+
Comment on attachment 9005512 [details] [diff] [review]
1485204-attendees-sizes-3.diff

It doesn't work. These need to be attributes.
Attachment #9005512 - Attachment is obsolete: true
Attachment #9003735 - Attachment is obsolete: false
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dd49319b2d85
Set sensible default sizes for attendees dialog, and fix broken datepicker widgets. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
You need to log in before you can comment on or make changes to this bug.