Closed
Bug 1485210
Opened 6 years ago
Closed 6 years ago
Add --sym-offsets=yes to valgrind command line
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
When valgrind prints out backtraces, it prints raw addresses and symbol names, but that doesn't help find the exact code that caused the errors, because we don't know where the libraries are loaded. With --sym-offsets=yes, it adds the offset from the symbol, which allows to find the relevant code in the binary.
Attachment #9002984 -
Flags: review?(n.nethercote)
|
||
Updated•6 years ago
|
Attachment #9002984 -
Flags: review?(n.nethercote) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f4a1596d18 Add --sym-offsets=yes to valgrind command line. r=njn
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b7f4a1596d18
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b7f4a1596d18
You need to log in
before you can comment on or make changes to this bug.
Description
•