Closed Bug 1485245 Opened 2 years ago Closed 2 years ago

Back out Move -> std::move change in 7zstub

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Version:
62 Branch
Platform:
x86
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: agashlin, Assigned: agashlin)

References

Details

Attachments

(1 file)

Bug 1485245: Back out Move -> std::move change in 7zstub. r?mhowell
46 bytes, text/x-phabricator-request
mhowell
: review+
Details | Review 
This got caught up in a mass-rename, the Move() in 7-Zip involves moving GUI elements, no relation to mozilla::Move() or std::move().

This code isn't often built from the tree, so it went unnoticed until I had to build it today.
Comment on attachment 9003021 [details]
Bug 1485245: Back out Move -> std::move change in 7zstub. r?mhowell

Matt Howell [:mhowell] has approved the revision.
Attachment #9003021 - Flags: review+
Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/427d2c99dcd4
Back out Move -> std::move change in 7zstub. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/427d2c99dcd4
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.