Closed
Bug 1485279
Opened 6 years ago
Closed 6 years ago
Merge nsISHEntryInternal and nsISHContainer into nsISHEntry
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(2 files, 1 obsolete file)
6.24 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
36.27 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
nsSHEntry is the only class that implements nsISHEntry, nsISHEntryInternal, and nsISHContainer. The latter two interfaces are small, so we can simplify things by merging them into nsISHEntry.
Assignee | ||
Comment 1•6 years ago
|
||
nsSHEntry is the only class that instantiates those two interfaces, so the separation is not useful. This lets us remove several pointless QIs. The patch also removes RemoveFromBFCache{AS,S}ync, which are unused.
Attachment #9003053 -
Flags: review?(kyle)
Assignee | ||
Comment 2•6 years ago
|
||
nsSHEntry is the only class that instantiates those two interfaces, so the separation is not useful. This lets us remove numerous pointless QIs.
Attachment #9003055 -
Flags: review?(kyle)
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #9003056 -
Flags: review?(kyle)
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Summary: Merge nsISHEntryInternal into nsISHEntry → Merge nsISHEntryInternal and nsISHContainer into nsISHEntry
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 9003056 [details] [diff] [review] Make nsISHEntry non-scriptable Nope, nsISHEntry must be scriptable.
Attachment #9003056 -
Attachment is obsolete: true
Attachment #9003056 -
Flags: review?(kyle)
Updated•6 years ago
|
Attachment #9003053 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #9003055 -
Flags: review?(kyle) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/33169047e425 Merge nsISHEntryInternal into nsISHEntry. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/6d3cc173cdde Merge nsISHContainer into nsISHEntry. r=qdot
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/33169047e425 https://hg.mozilla.org/mozilla-central/rev/6d3cc173cdde
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•