Closed Bug 1485279 Opened 1 year ago Closed 1 year ago

Merge nsISHEntryInternal and nsISHContainer into nsISHEntry

Categories

(Core :: DOM: Navigation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files, 1 obsolete file)

nsSHEntry is the only class that implements nsISHEntry, nsISHEntryInternal, and
nsISHContainer. The latter two interfaces are small, so we can simplify things
by merging them into nsISHEntry.
nsSHEntry is the only class that instantiates those two interfaces, so the
separation is not useful. This lets us remove several pointless QIs.

The patch also removes RemoveFromBFCache{AS,S}ync, which are unused.
Attachment #9003053 - Flags: review?(kyle)
nsSHEntry is the only class that instantiates those two interfaces, so the
separation is not useful. This lets us remove numerous pointless QIs.
Attachment #9003055 - Flags: review?(kyle)
Priority: -- → P2
Summary: Merge nsISHEntryInternal into nsISHEntry → Merge nsISHEntryInternal and nsISHContainer into nsISHEntry
Comment on attachment 9003056 [details] [diff] [review]
Make nsISHEntry non-scriptable

Nope, nsISHEntry must be scriptable.
Attachment #9003056 - Attachment is obsolete: true
Attachment #9003056 - Flags: review?(kyle)
Attachment #9003053 - Flags: review?(kyle) → review+
Attachment #9003055 - Flags: review?(kyle) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33169047e425
Merge nsISHEntryInternal into nsISHEntry. r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d3cc173cdde
Merge nsISHContainer into nsISHEntry. r=qdot
https://hg.mozilla.org/mozilla-central/rev/33169047e425
https://hg.mozilla.org/mozilla-central/rev/6d3cc173cdde
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.