Closed
Bug 1485300
Opened 6 years ago
Closed 6 years ago
Duplicated NetworkObserver implementation
Categories
(DevTools :: Netmonitor, enhancement, P1)
DevTools
Netmonitor
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: Honza, Assigned: ochameau)
Details
Attachments
(1 file)
This is a follow up for bug 1482070 I am seeing NetworkObserver object implementation in two files: 1) server/actors/network-monitor/network-observer.js 2) server/actors/network-monitor/network-response-listener.js It should live in #1 only See also: https://searchfox.org/mozilla-central/search?q=NetworkObserver.prototype+%3D+%7B&case=true&path= Honza
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → poirot.alex
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: F3yDYfmsv59
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ae1e36972309b7ead604f0733dd8b2509e08f68 (I fixed eslint in the last revision)
|
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 9003107 [details] Bug 1485300 - Remove duplicated implementation of NetworkObserver. r=Honza Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9003107 -
Flags: review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6fe10cab33ca Remove duplicated implementation of NetworkObserver. r=Honza
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6fe10cab33ca
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•