Closed Bug 1485320 Opened 2 years ago Closed 2 years ago

MemoryOutputStream.cpp uses GetMutableData() as a complex SetLength()

Categories

(Core :: Storage: Quota Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MemoryOutputStream.cpp uses GetMutableData() as a complex SetLength(). GetMutableData() is a rarely-used redundant API that would be nice to remove (bug 1485026), so let's just use the more obvious SetLength().
Comment on attachment 9003094 [details]
Bug 1485320 - Use SetLength() instead of GetMutableData() throwing away the pointer in MemoryOutputStream::Create().

Andrew Sutherland [:asuth] has approved the revision.
Attachment #9003094 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2616aee4d44
Use SetLength() instead of GetMutableData() throwing away the pointer in MemoryOutputStream::Create(). r=asuth
https://hg.mozilla.org/mozilla-central/rev/c2616aee4d44
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.