Closed
Bug 1485343
Opened 6 years ago
Closed 6 years ago
FTP code uses isdigit()
Categories
(Core Graveyard :: Networking: FTP, defect, P3)
Core Graveyard
Networking: FTP
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged])
Attachments
(1 file)
Per https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isdigit-iswdigit-isdigit-l-iswdigit-l isdigit() locale-dependent on Windows and https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c gives an example of how. mozilla::IsAsciiDigit() should be used in place of isdigit().
|
||
Comment 1•6 years ago
|
||
should change netwerk/protocol/ftp/nsFtpConnectionThread.cpp netwerk/streamconv/converters/ParseFTPList.cpp
|
Assignee | |
Comment 2•6 years ago
|
||
MozReview-Commit-ID: CXcluPKLwIv
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try run (not sure if we actually have FTP tests): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3713d19b4a02305cd3966718baf9d1df690df60
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9004152 [details] Bug 1485343 - Avoid locale-dependent C standard library functions in FTP code. Valentin Gosu [:valentin] has approved the revision.
Attachment #9004152 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4095afaecf59 Avoid locale-dependent C standard library functions in FTP code. r=valentin
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4095afaecf59
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•3 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•