1485367 - disable libjpeg-turbo support for aarch64 windows

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

When we set up LIBJPEG_TURBO_ASFLAGS:

https://searchfox.org/mozilla-central/source/old-configure.in#2782-2793

We assume aarch64 is Unix-y, which is an invalid assumption, which then leads to the build breaking when armasm64 is used on these assembly files.

Maybe we should also think about writing aarch64 Windows code here to ensure that JPEG files are decoded quickly...

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: disable libjpeg-turbo support for aarch64 windows

Some support may be coming:

https://github.com/libjpeg-turbo/libjpeg-turbo/pull/229

But it's not here yet, so we can just disable this.

Comment 2

[(Away)]

Comment on attachment 9003175 [details] [diff] [review]
disable libjpeg-turbo support for aarch64 windows

Review of attachment 9003175 [details] [diff] [review]:
-----------------------------------------------------------------

Is LIBJPEG_TURBO_AS used anywhere?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to David Major [:dmajor] from comment #2)
> Is LIBJPEG_TURBO_AS used anywhere?

Apparently not.  We should just delete that, then?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b33554a2d2cd
disable libjpeg-turbo support for aarch64 windows; r=dmajor

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b33554a2d2cd