disable libjpeg-turbo support for aarch64 windows

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
ARM64
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
When we set up LIBJPEG_TURBO_ASFLAGS:

https://searchfox.org/mozilla-central/source/old-configure.in#2782-2793

We assume aarch64 is Unix-y, which is an invalid assumption, which then leads to the build breaking when armasm64 is used on these assembly files.

Maybe we should also think about writing aarch64 Windows code here to ensure that JPEG files are decoded quickly...
Assignee

Comment 1

10 months ago
Some support may be coming:

https://github.com/libjpeg-turbo/libjpeg-turbo/pull/229

But it's not here yet, so we can just disable this.
Attachment #9003175 - Flags: review?(core-build-config-reviews)
Assignee

Updated

10 months ago
Assignee: nobody → nfroyd
Comment on attachment 9003175 [details] [diff] [review]
disable libjpeg-turbo support for aarch64 windows

Review of attachment 9003175 [details] [diff] [review]:
-----------------------------------------------------------------

Is LIBJPEG_TURBO_AS used anywhere?
Attachment #9003175 - Flags: review?(core-build-config-reviews) → review+
Assignee

Comment 3

10 months ago
(In reply to David Major [:dmajor] from comment #2)
> Is LIBJPEG_TURBO_AS used anywhere?

Apparently not.  We should just delete that, then?

Comment 4

10 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b33554a2d2cd
disable libjpeg-turbo support for aarch64 windows; r=dmajor

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b33554a2d2cd
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.