Closed Bug 1485367 Opened 2 years ago Closed 2 years ago

disable libjpeg-turbo support for aarch64 windows

Categories

(Core :: General, enhancement)

ARM64
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we set up LIBJPEG_TURBO_ASFLAGS:

https://searchfox.org/mozilla-central/source/old-configure.in#2782-2793

We assume aarch64 is Unix-y, which is an invalid assumption, which then leads to the build breaking when armasm64 is used on these assembly files.

Maybe we should also think about writing aarch64 Windows code here to ensure that JPEG files are decoded quickly...
Some support may be coming:

https://github.com/libjpeg-turbo/libjpeg-turbo/pull/229

But it's not here yet, so we can just disable this.
Attachment #9003175 - Flags: review?(core-build-config-reviews)
Assignee: nobody → nfroyd
Comment on attachment 9003175 [details] [diff] [review]
disable libjpeg-turbo support for aarch64 windows

Review of attachment 9003175 [details] [diff] [review]:
-----------------------------------------------------------------

Is LIBJPEG_TURBO_AS used anywhere?
Attachment #9003175 - Flags: review?(core-build-config-reviews) → review+
(In reply to David Major [:dmajor] from comment #2)
> Is LIBJPEG_TURBO_AS used anywhere?

Apparently not.  We should just delete that, then?
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b33554a2d2cd
disable libjpeg-turbo support for aarch64 windows; r=dmajor
https://hg.mozilla.org/mozilla-central/rev/b33554a2d2cd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.