Closed Bug 1485400 Opened 3 years ago Closed 3 years ago

Expose document.numTrackersFound even if FastBlock and TP are disabled

Categories

(Toolkit :: Safe Browsing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: johannh, Assigned: xeonchen)

References

Details

Attachments

(2 files)

For the FastBlock Shield study, we need to query document.numTrackersFound when no resources were blocked, which is currently not possible the way that this number is incremented:

https://searchfox.org/mozilla-central/source/netwerk/base/nsChannelClassifier.cpp#907

Maybe it's enough to put it here instead? https://searchfox.org/mozilla-central/source/netwerk/base/nsChannelClassifier.cpp#1225

Also I have the feeling that this also means it's only reporting FastBlock trackers that were blocked, not the ones that were not blocked by FastBlock.

We have a bunch of test cases in https://github.com/mozilla/FastBlockShield/pull/61 that should succeed to resolve this bug.

Thanks!
make counter increased when trackers are found
Comment on attachment 9003429 [details]
Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer

:johannh, can you help to see if this patch works for you tests? Or is there any document that I can run those tests manually?
Attachment #9003429 - Flags: feedback?(jhofmann)
Comment on attachment 9003429 [details]
Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer

Hmm running this through the shield study build system I get really weird results (nothing works) and crashiness, but running it with ./mach run seems to work fine and

gBrowser.selectedBrowser.messageManager.loadFrameScript('data:,console.log(docShell.document.numTrackersFound)', false);

logs the expected amount of trackers, while it does not on release, so I would tend to say this is a good patch and that I have to figure out the issues we're having on our end (maybe it will go away once this is in Nightly).
Attachment #9003429 - Flags: feedback?(jhofmann) → feedback+
Comment on attachment 9003429 [details]
Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer

Seems Phabricator didn't request for review here
Attachment #9003429 - Flags: review?(honzab.moz)
Comment on attachment 9003429 [details]
Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer

Cancel review because I found some issues while writing test cases.
Attachment #9003429 - Flags: review?(honzab.moz)
Attachment #9003429 - Attachment is obsolete: true
separate tracker counter API
Comment on attachment 9004698 [details]
Bug 1485400 - Part 0: separate blocked tracker counter; r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9004698 - Flags: review+
Attachment #9003429 - Attachment is obsolete: false
Attachment #9003429 - Attachment description: Bug 1485400 - fix counter of numTrackersFound → Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer
After some changes in our code and using an opt version from try I can confirm that this fixes our issues and our tests are passing, thank you!
Comment on attachment 9003429 [details]
Bug 1485400 - Part 1: fix tracker found/blocked counter; r=mayhemer

Honza Bambas (:mayhemer) has approved the revision.
Attachment #9003429 - Flags: review+
Keywords: checkin-needed
Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9370432b26ad
Part 0: separate blocked tracker counter; r=smaug
Keywords: checkin-needed
Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c476aa79a8ca
Part 1: fix tracker found/blocked counter; r=mayhemer
Backed out 2 changesets (bug 1485400) for build bustage at build/src/netwerk/base/nsChannelClassifier.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/8d89bfeb0b2f480a638e83a7d0178039033438f1

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9370432b26adcd6399e586190a47d4c8a8cdc56d&selectedJob=196910539

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196910539&repo=autoland&lineNumber=13095

[task 2018-08-31T15:45:01.363Z] 15:45:01     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/res'
[task 2018-08-31T15:45:01.366Z] 15:45:01     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/res'
[task 2018-08-31T15:45:01.367Z] 15:45:01     INFO -  netwerk/protocol/res
[task 2018-08-31T15:45:01.367Z] 15:45:01     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/res'
[task 2018-08-31T15:45:01.367Z] 15:45:01     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/res'
[task 2018-08-31T15:45:01.367Z] 15:45:01     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/res'
[task 2018-08-31T15:45:02.362Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/about'
[task 2018-08-31T15:45:02.362Z] 15:45:02     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_protocol_about0.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/protocol/about -I/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/about -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/netwerk/cache2 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_protocol_about0.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/about/Unified_cpp_protocol_about0.cpp
[task 2018-08-31T15:45:02.362Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/about'
[task 2018-08-31T15:45:02.363Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.363Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.363Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.363Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.600Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-08-31T15:45:02.600Z] 15:45:02     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_netwerk_base1.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/netwerk/socket -I/builds/worker/workspace/build/src/security/pkix/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_netwerk_base1.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/base/Unified_cpp_netwerk_base1.cpp
[task 2018-08-31T15:45:02.600Z] 15:45:02     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/netwerk/base/Unified_cpp_netwerk_base1.cpp:137:
[task 2018-08-31T15:45:02.600Z] 15:45:02     INFO -  /builds/worker/workspace/build/src/netwerk/base/nsChannelClassifier.cpp:914:30: error: too many arguments to function call, expected 0, have 1
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -    doc->IncrementTrackerCount(true);
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -    ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIDocument.h:3558:3: note: 'IncrementTrackerCount' declared here
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -    void IncrementTrackerCount()
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -    ^
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -  1 error generated.
[task 2018-08-31T15:45:02.601Z] 15:45:02     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1110: recipe for target 'Unified_cpp_netwerk_base1.o' failed
[task 2018-08-31T15:45:02.602Z] 15:45:02     INFO -  make[4]: *** [Unified_cpp_netwerk_base1.o] Error 1
[task 2018-08-31T15:45:02.602Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2018-08-31T15:45:02.602Z] 15:45:02     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2018-08-31T15:45:02.602Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.602Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.605Z] 15:45:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:02.605Z] 15:45:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:05.366Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/data'
[task 2018-08-31T15:45:05.367Z] 15:45:05     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_protocol_data0.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/protocol/data -I/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/data -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/Unified_cpp_protocol_data0.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/data/Unified_cpp_protocol_data0.cpp
[task 2018-08-31T15:45:05.368Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/data'
[task 2018-08-31T15:45:05.385Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.385Z] 15:45:05     INFO -  mkdir -p '.deps/'
[task 2018-08-31T15:45:05.386Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.386Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.387Z] 15:45:05     INFO -  netwerk/protocol/viewsource
[task 2018-08-31T15:45:05.387Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.387Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.387Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/viewsource'
[task 2018-08-31T15:45:05.442Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/cache2'
[task 2018-08-31T15:45:05.442Z] 15:45:05     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_netwerk_cache21.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/cache2 -I/builds/worker/workspace/build/src/obj-firefox/netwerk/cache2 -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/netwerk/cache -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_netwerk_cache21.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/cache2/Unified_cpp_netwerk_cache21.cpp
[task 2018-08-31T15:45:05.442Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/cache2'
[task 2018-08-31T15:45:05.458Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:05.458Z] 15:45:05     INFO -  mkdir -p '.deps/'
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  netwerk/protocol/websocket
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:05.459Z] 15:45:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/websocket'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/file'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_protocol_file0.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/protocol/file -I/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/file -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_protocol_file0.o.pp   /builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/file/Unified_cpp_protocol_file0.cpp
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/file'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:07.630Z] 15:45:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:11.517Z] 15:45:11     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:11.521Z] 15:45:11     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o nsHttpChannelAuthProvider.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DHAS_CONNECTX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/protocol/http -I/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/netwerk/cookie -I/builds/worker/workspace/build/src/security/pkix/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/nsHttpChannelAuthProvider.o.pp   /builds/worker/workspace/build/src/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp
[task 2018-08-31T15:45:11.521Z] 15:45:11     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2018-08-31T15:45:11.542Z] 15:45:11     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/wyciwyg'
[task 2018-08-31T15:45:11.542Z] 15:45:11     INFO -  mkdir -p '.deps/'
Flags: needinfo?(xeonchen)
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3897c3140df0
Part 0: separate blocked tracker counter; r=smaug
https://hg.mozilla.org/integration/autoland/rev/70042a7ea627
Part 1: fix tracker found/blocked counter; r=mayhemer
(In reply to Pulsebot from comment #14)
> Pushed by ccoroiu@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/3897c3140df0
> Part 0: separate blocked tracker counter; r=smaug
> https://hg.mozilla.org/integration/autoland/rev/70042a7ea627
> Part 1: fix tracker found/blocked counter; r=mayhemer

Those patches have to land together, thank you!
Flags: needinfo?(xeonchen)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/0aa31e702587
Remove ')' from merge conflict. a=bustage-fix
https://hg.mozilla.org/mozilla-central/rev/3897c3140df0
https://hg.mozilla.org/mozilla-central/rev/70042a7ea627
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.