1485454 - Use absolute path in codespell linter

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Andrew Halberstadt [:ahal]]

While working on bug 1460856 I discovered that the codespell linter is using relative paths. This means that codespell issues are grouped separately from other linters' issues (since the 'path' is used as a key in the issues dict).

Mozlint should probably enforce absolute paths so this doesn't accidentally happen again.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=Sylvestre

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=Sylvestre

After fixing the absolute path issue in codespell, I noticed that the stylish
formatter doesn't indent lint issues that don't have a column properly. This
was never noticed before since most other linters have a column attribute.

Depends on D4012

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9003273 [details]
Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=Sylvestre

Sylvestre Ledru [:sylvestre] has approved the revision.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9003272 [details]
Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=Sylvestre

Sylvestre Ledru [:sylvestre] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb3227f5156c
[lint] Use absolute paths with the codespell linter, r=sylvestre

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1586964885f9
[mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cb3227f5156c
https://hg.mozilla.org/mozilla-central/rev/1586964885f9