1485477 - clean up socorro.lib and do a dead-code pass

Status: RESOLVED FIXED

(Socorro :: General, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

There's a bunch of code in socorro.lib that's dead code:

* socorro/lib/buildtype.py
* socorro/lib/citexttype.py
* socorro/lib/jsontype.py
* socorro/lib/ver_tools.py

The first three are imported, but not used, in migrations. The last isn't used at all. Interestingly, I wrote a similar function in build_default_context in the webapp so I could sort version numbers.

This bug covers removing these bits and fixing the migrations so as not to import them.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4570: bug 1485477: clean up unused modules

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/d4e9d9f4ebcaaad542daebae30860800b0f42c0b
bug 1485477: clean up unused modules

This removes modules in socorro.lib that are unused.

https://github.com/mozilla-services/socorro/commit/96f10782cbbdc48e2869703174d979e5fea2c1ea
Merge pull request #4570 from willkg/1485477-cleanup

bug 1485477: clean up unused modules

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

We should remove socorro/processor/breakpad_pipe_to_json.py. We don't have anything in pipe format anymore, so no need for this.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4584: bug 1485477: remove breakpad_pipe_to_json.py code

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/a381eda906cc35c6d0cce4973e3add4ac55ad075
bug 1485477: remove breakpad_pipe_to_json.py code

We don't use this in Socorro, so we should remove it.

https://github.com/mozilla-services/socorro/commit/e7bb2cf0439baf4e029004635a2f90d86ac20b26
Merge pull request #4584 from willkg/1485477-more-dead-code

bug 1485477: remove breakpad_pipe_to_json.py code

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Everything I was thinking of covering is covered now. Closing this out.