Closed Bug 1485485 Opened 2 years ago Closed 2 years ago
don't require rustc/cargo to be on PATH during bootstrap
I hit this block of code today: https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/base.py#628-638 which is out-of-date now that we look in ~/.cargo/bin for rustc/cargo in addition to looking for them on PATH. We should redo our rustc/cargo detection logic to do the same thing as configure here.
moz.configure looks for rustc/cargo on PATH and in ~/.cargo/bin. Bootstrap only looks on PATH and not in ~/.cargo/bin, though it is smart enough to complain if rustc/cargo can't be found on PATH and you have them in ~/.cargo/bin. Bootstrap should look in both places by default, and be content if it finds them wherever they are, so long as moz.configure can find them.
Attachment #9003562 - Flags: review?(core-build-config-reviews)
2 years ago
Attachment #9003562 - Flags: review?(core-build-config-reviews) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/514f97264e6c make bootstrap accept rustc/cargo in known-good locations; r=chmanchester
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb7606a2b12 Followup: Fix which function definition in derrived classes. r=froydnj
You need to log in before you can comment on or make changes to this bug.