Closed Bug 1485485 Opened Last year Closed Last year

don't require rustc/cargo to be on PATH during bootstrap

Categories

(Firefox Build System :: Bootstrap Configuration, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

I hit this block of code today:

https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/base.py#628-638

which is out-of-date now that we look in ~/.cargo/bin for rustc/cargo in addition to looking for them on PATH.

We should redo our rustc/cargo detection logic to do the same thing as configure here.
moz.configure looks for rustc/cargo on PATH and in ~/.cargo/bin.
Bootstrap only looks on PATH and not in ~/.cargo/bin, though it is smart
enough to complain if rustc/cargo can't be found on PATH and you have
them in ~/.cargo/bin.  Bootstrap should look in both places by default,
and be content if it finds them wherever they are, so long as
moz.configure can find them.
Attachment #9003562 - Flags: review?(core-build-config-reviews)
Assignee: nobody → nfroyd
Attachment #9003562 - Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/514f97264e6c
make bootstrap accept rustc/cargo in known-good locations; r=chmanchester
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb7606a2b12
Followup: Fix which function definition in derrived classes. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/514f97264e6c
https://hg.mozilla.org/mozilla-central/rev/7eb7606a2b12
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.