1485485 - don't require rustc/cargo to be on PATH during bootstrap

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Nathan Froyd [:froydnj]]

I hit this block of code today:

https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/base.py#628-638

which is out-of-date now that we look in ~/.cargo/bin for rustc/cargo in addition to looking for them on PATH.

We should redo our rustc/cargo detection logic to do the same thing as configure here.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make bootstrap accept rustc/cargo in known-good locations

moz.configure looks for rustc/cargo on PATH and in ~/.cargo/bin.
Bootstrap only looks on PATH and not in ~/.cargo/bin, though it is smart
enough to complain if rustc/cargo can't be found on PATH and you have
them in ~/.cargo/bin.  Bootstrap should look in both places by default,
and be content if it finds them wherever they are, so long as
moz.configure can find them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/514f97264e6c
make bootstrap accept rustc/cargo in known-good locations; r=chmanchester

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb7606a2b12
Followup: Fix which function definition in derrived classes. r=froydnj

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/514f97264e6c
https://hg.mozilla.org/mozilla-central/rev/7eb7606a2b12