Closed Bug 1485487 Opened 2 years ago Closed 2 years ago

mozilla::glue::DllServices::GetBinaryOrgName should assert if called on Gecko main thread

Categories

(Core :: mozglue, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

This function does file I/O. While it is often likely that the file in question is already in the page cache, we cannot rely on that for perf guarantees.

Let's assert so that we never call this inappropriately.
Summary: mozilla::glue::DllServices::GetBinaryOrgName should assert if not called on Gecko main thread → mozilla::glue::DllServices::GetBinaryOrgName should assert if called on Gecko main thread
Attachment #9003283 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/17626f41c0e5bf764b7021f240787bee47d2c393
Bug 1485487: Add an assertion to ensure that DllServices::GetBinaryOrgName is not called on the Gecko main thread; r=mhowell
https://hg.mozilla.org/mozilla-central/rev/17626f41c0e5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.