Closed
Bug 1485487
Opened 6 years ago
Closed 6 years ago
mozilla::glue::DllServices::GetBinaryOrgName should assert if called on Gecko main thread
Categories
(Core :: mozglue, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
Attachments
(1 file)
|
2.59 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
This function does file I/O. While it is often likely that the file in question is already in the page cache, we cannot rely on that for perf guarantees. Let's assert so that we never call this inappropriately.
|
Assignee | |
Updated•6 years ago
|
Summary: mozilla::glue::DllServices::GetBinaryOrgName should assert if not called on Gecko main thread → mozilla::glue::DllServices::GetBinaryOrgName should assert if called on Gecko main thread
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9003283 -
Flags: review?(mhowell)
|
||
Updated•6 years ago
|
Attachment #9003283 -
Flags: review?(mhowell) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/17626f41c0e5bf764b7021f240787bee47d2c393 Bug 1485487: Add an assertion to ensure that DllServices::GetBinaryOrgName is not called on the Gecko main thread; r=mhowell
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/17626f41c0e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•