1485494 - Remove the XPCOM registration for RedirectChannelRegistrar

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Comment 1

[(no longer active)]

Attachment: Remove the XPCOM registration for RedirectChannelRegistrar

Comment 2

[(no longer active)]

Attachment: Remove the XPCOM registration for RedirectChannelRegistrar

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 9003813 [details] [diff] [review]
Remove the XPCOM registration for RedirectChannelRegistrar

Review of attachment 9003813 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

::: netwerk/base/RedirectChannelRegistrar.cpp
@@ +29,5 @@
> +{
> +  if (!gSingleton) {
> +    gSingleton = new RedirectChannelRegistrar();
> +  }
> +  return do_AddRef(gSingleton);

please assert main thread (before the return), concern about https://www.janbambas.cz/illusion-atomic-reference-counting/

@@ +36,5 @@
> +// static
> +void
> +RedirectChannelRegistrar::Shutdown()
> +{
> +  gSingleton = nullptr;

as well here, same reason

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46aae0280fd6
Remove the XPCOM registration for RedirectChannelRegistrar; r=mayhemer

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/46aae0280fd6