Remove the XPCOM registration for RedirectChannelRegistrar

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Assignee: nobody → ehsan
Blocks: 1477576
Attachment #9003279 - Flags: review?(honzab.moz)
Priority: -- → P3
Whiteboard: [necko-triaged]
Attachment #9003279 - Attachment is obsolete: true
Attachment #9003279 - Flags: review?(honzab.moz)
Comment on attachment 9003813 [details] [diff] [review]
Remove the XPCOM registration for RedirectChannelRegistrar

Review of attachment 9003813 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

::: netwerk/base/RedirectChannelRegistrar.cpp
@@ +29,5 @@
> +{
> +  if (!gSingleton) {
> +    gSingleton = new RedirectChannelRegistrar();
> +  }
> +  return do_AddRef(gSingleton);

please assert main thread (before the return), concern about https://www.janbambas.cz/illusion-atomic-reference-counting/

@@ +36,5 @@
> +// static
> +void
> +RedirectChannelRegistrar::Shutdown()
> +{
> +  gSingleton = nullptr;

as well here, same reason
Attachment #9003813 - Flags: review?(honzab.moz) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46aae0280fd6
Remove the XPCOM registration for RedirectChannelRegistrar; r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/46aae0280fd6
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.