Closed Bug 1485541 Opened Last year Closed Last year

Experimental APIs can't define lifecycle events

Categories

(WebExtensions :: Experiments, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: markh, Assigned: aswan)

Details

Attachments

(1 file)

https://firefox-source-docs.mozilla.org/toolkit/components/extensions/webextensions/lifecycle.html documents that APIs can define lifecycle events. However, attempts by an experimental API to define these events fails.

The schema definition at https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/toolkit/components/extensions/schemas/experiments.json#105 only allows for a "startup" event. Even if we add the new events there, they never fire, because (IIUC), the experiment manager is a LazyAPIManager rather than an apiManager defined in ExtensionParent.jsm, which is where support for these events is wired up.
The problem with uninstall and update events is much larger: they require running code from an extension that is not active.
Flags: needinfo?(aswan)
Assignee: nobody → aswan
Flags: needinfo?(aswan)
Comment on attachment 9006378 [details]
Bug 1485541 Clarify documentation on extension lifecycle events

Kris Maglione [:kmag] has approved the revision.
Attachment #9006378 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f84a0a8794302974c1706b33065e5d71629958
Bug 1485541 Clarify documentation on extension lifecycle events DONTBUILD r=kmag
https://hg.mozilla.org/mozilla-central/rev/d6f84a0a8794
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(aswan)
This patch was just a documentation update
Flags: needinfo?(aswan) → qe-verify-
You need to log in before you can comment on or make changes to this bug.