1485541 - Experimental APIs can't define lifecycle events

Status: RESOLVED FIXED

(WebExtensions :: Experiments, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

https://firefox-source-docs.mozilla.org/toolkit/components/extensions/webextensions/lifecycle.html documents that APIs can define lifecycle events. However, attempts by an experimental API to define these events fails.

The schema definition at https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/toolkit/components/extensions/schemas/experiments.json#105 only allows for a "startup" event. Even if we add the new events there, they never fire, because (IIUC), the experiment manager is a LazyAPIManager rather than an apiManager defined in ExtensionParent.jsm, which is where support for these events is wired up.

Comment 1

[Andrew Swan [:aswan]]

The problem with uninstall and update events is much larger: they require running code from an extension that is not active.

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1485541 Clarify documentation on extension lifecycle events

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 9006378 [details]
Bug 1485541 Clarify documentation on extension lifecycle events

Kris Maglione [:kmag] has approved the revision.

Comment 4

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f84a0a8794302974c1706b33065e5d71629958
Bug 1485541 Clarify documentation on extension lifecycle events DONTBUILD r=kmag

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d6f84a0a8794

Comment 6

[Vlad Jiman]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 7

[Andrew Swan [:aswan]]

This patch was just a documentation update