Closed
Bug 1485593
Opened 6 years ago
Closed 6 years ago
FontPropertyTypes.h uses isdigit()
Categories
(Core :: Graphics: Text, defect, P3)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: nical)
References
(Blocks 1 open bug)
Details
(Whiteboard: gfx-noted)
Attachments
(1 file)
Per https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isdigit-iswdigit-isdigit-l-iswdigit-l isdigit() locale-dependent on Windows and https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c gives an example of how. mozilla::IsAsciiDigit() should be used in place of isdigit().
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → nical.bugzilla
Priority: -- → P3
Whiteboard: gfx-noted
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9003420 [details] Bug 1485593 - Avoid using isdigit. r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9003420 -
Flags: review+
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/613debd35609 Avoid using isdigit. r=hsivonen
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/613debd35609
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•