1485599 - Color sidebar scrollbars according to sidebar properties

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P5)

Description

[Tim Nguyen :ntim]

We can use the scrollbar-face-color and scrollbar-track-color properties to do this.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1485599 - Color sidebar scrollbars according to sidebar properties. r?dao

Comment 2

[Tim Nguyen :ntim]

Note that this depends on bug 1501586

Comment 3

[Richard Marti (:Paenglab)]

Attachment: scrollbars-windows.png

With this colours, the scrollbar up/down arrows are almost not visible with a light theme and with the dark theme not visible on Windows.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: scrollbar-proposal.png

Tim, what do you think about this? With this colours are the arrows visible.

I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 9020626 [details]
scrollbar-proposal.png

(In reply to Richard Marti (:Paenglab) from comment #4)
> Created attachment 9020626 [details]
> scrollbar-proposal.png
> 
> Tim, what do you think about this? With this colours are the arrows visible.
> 
> I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);

Looks good to me! Can you post screenshots of MacOS and Linux as well ?

Amy, could you please look at this proposal ? Right now, the scrollbars are light regardless of the theme and we'd like to switch to alpha colors to make sure they blend in well for the dark theme too.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: scrollbar-proposal-Linux.png

Scrollbars on Ubuntu with the proposed scrollbar colours.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: scrollbar-proposal-Mac.png

Scrollbars on Mac with the proposed scrollbar colours.

Comment 8

[Amy Lee [:amylee] UX]

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #5)
> Comment on attachment 9020626 [details]
> scrollbar-proposal.png
> 
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Created attachment 9020626 [details]
> > scrollbar-proposal.png
> > 
> > Tim, what do you think about this? With this colours are the arrows visible.
> > 
> > I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> > [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
> 
> Looks good to me! Can you post screenshots of MacOS and Linux as well ?
> 
> Amy, could you please look at this proposal ? Right now, the scrollbars are
> light regardless of the theme and we'd like to switch to alpha colors to
> make sure they blend in well for the dark theme too.

This looks good to me. Thanks

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1485599-colorScrollbars.patch

Tim, I have no phabricator configured. Does obsoleting the phabricator patch in bugzilla also obsolete the patch in phabricator? If not, please could you do it?

Comment 10

[Tim Nguyen :ntim]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b068e567617b32e0776f6d8510f9ae77807e8589

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b068e567617b