Closed Bug 1485599 Opened 3 years ago Closed 3 years ago

Color sidebar scrollbars according to sidebar properties

Categories

(Firefox :: Theme, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ntim, Assigned: Paenglab)

References

Details

Attachments

(4 files, 2 obsolete files)

We can use the scrollbar-face-color and scrollbar-track-color properties to do this.
Priority: -- → P5
Blocks: 1385518
Assignee: nobody → ntim.bugs
Depends on: 1498216, 1494607
Depends on: 1501586
Note that this depends on bug 1501586
Attached image scrollbars-windows.png (obsolete) —
With this colours, the scrollbar up/down arrows are almost not visible with a light theme and with the dark theme not visible on Windows.
Assignee: ntim.bugs → nobody
Attached image scrollbar-proposal.png
Tim, what do you think about this? With this colours are the arrows visible.

I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
Attachment #9020626 - Flags: feedback?(ntim.bugs)
Comment on attachment 9020626 [details]
scrollbar-proposal.png

(In reply to Richard Marti (:Paenglab) from comment #4)
> Created attachment 9020626 [details]
> scrollbar-proposal.png
> 
> Tim, what do you think about this? With this colours are the arrows visible.
> 
> I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);

Looks good to me! Can you post screenshots of MacOS and Linux as well ?

Amy, could you please look at this proposal ? Right now, the scrollbars are light regardless of the theme and we'd like to switch to alpha colors to make sure they blend in well for the dark theme too.
Attachment #9020626 - Flags: feedback?(ntim.bugs)
Attachment #9020626 - Flags: feedback?(amlee)
Attachment #9020626 - Flags: feedback+
Assignee: nobody → richard.marti
Scrollbars on Ubuntu with the proposed scrollbar colours.
Scrollbars on Mac with the proposed scrollbar colours.
Attachment #9020601 - Attachment is obsolete: true
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #5)
> Comment on attachment 9020626 [details]
> scrollbar-proposal.png
> 
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Created attachment 9020626 [details]
> > scrollbar-proposal.png
> > 
> > Tim, what do you think about this? With this colours are the arrows visible.
> > 
> > I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> > [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
> 
> Looks good to me! Can you post screenshots of MacOS and Linux as well ?
> 
> Amy, could you please look at this proposal ? Right now, the scrollbars are
> light regardless of the theme and we'd like to switch to alpha colors to
> make sure they blend in well for the dark theme too.

This looks good to me. Thanks
Tim, I have no phabricator configured. Does obsoleting the phabricator patch in bugzilla also obsolete the patch in phabricator? If not, please could you do it?
Attachment #9019597 - Attachment is obsolete: true
Attachment #9020837 - Flags: review?(dao+bmo)
Attachment #9020837 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Attachment #9020626 - Flags: feedback?(amlee)
https://hg.mozilla.org/mozilla-central/rev/b068e567617b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.