Closed Bug 14856 Opened 21 years ago Closed 20 years ago

gtk generates incorrect key events for keyrepeat

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: Brade, Assigned: blizzard)

References

Details

(Keywords: platform-parity)

Attachments

(2 files)

GTK currently generates extra key down and key up events for each repeated key
press.  Instead, the event chain should look like:
  keydown, keypress, keypress, keypress, keypress..., keyup

This is per the DOM specification and 4.x compatibility:  http://www.w3.org/TR/
WD-DOM-Level-2/events.html#Events-eventgroupings-keyevents
Looks like gtk is sending key release events even when no key was released; I
wonder if we'll have to go to xlib in order to suppress the fictitious events?
Or does gtk have some way of handling this?  If we could avoid getting the key
release events, then the handle_key_press_event code could suppress the KeyDown
event in the case where we already had a KeyDown for that keycode and haven't
gotten a KeyUp yet, or something to that effect.
Blocks: 15693
Status: NEW → ASSIGNED
Target Milestone: M11
mass-moving most m11 bugs to m12
Mass-moving non-PDT+ bugs to M13
does it still do this now that we are using superwin and generating our own key
events?
Yes, it still happens.  If you hold a key down, we still get a sequence of key
down, key press, key up, key down, key press, key up, etc. as long as the key is
held down.
Target Milestone: M13 → M15
Keywords: pp
Summary: [pp] gtk generates incorrect key events for keyrepeat → gtk generates incorrect key events for keyrepeat
blizzard, could you please look at this?
Assignee: pavlov → blizzard
Status: ASSIGNED → NEW
moving out...
Target Milestone: M15 → M16
Status: NEW → ASSIGNED
Attached patch patch to fixSplinter Review
Attached patch test scriptSplinter Review
r=syd, fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Please ignore the spam.  Changing address.
Assignee: blizzard → blizzard
Status: RESOLVED → NEW
bustage from my reassign
Status: NEW → RESOLVED
Closed: 20 years ago20 years ago
Mass update:  changing qacontact to ckritzer@netscape.com
QA Contact: janc → ckritzer
This bug is back from the checkin that fixed bug #46901.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Re-checked in.
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Updating QA Contact.
QA Contact: ckritzer → lorca
Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.
QA Contact: lorca → gerardok
QA contact updated
QA Contact: gerardok → madhur
verified on build 2001-08-07-08-trunk
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.