Avoid copy relocations in binaries we build

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
7 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

See bug 1485562 for an example of bad things that can happen with such relocations, and see also https://github.com/llvm-mirror/lld/blob/c90379ddfe5eefdcb8edcaca5fa90a831505ae18/ELF/Relocations.cpp#L496-L537
Attachment #9003411 - Flags: review?(core-build-config-reviews)
Comment on attachment 9003411 [details] [diff] [review]
Avoid copy relocations in binaries we build

Review of attachment 9003411 [details] [diff] [review]:
-----------------------------------------------------------------

That's quite a comment.

Is this going to wreak havoc with downstream linux distros who unwittingly turn on LTO, and then have to deal with e.g. Nautilus not recognizing Firefox as an executable?  (cf https://bugzilla.redhat.com/show_bug.cgi?id=1296858 or https://bugzilla.mozilla.org/show_bug.cgi?id=1360301)  Or even a downstream packager using our Firefox packages, or even just ordinary users who use our packages, since we want LTO turned on for such packages?

I think the old-configure.in changes are OK, but I'm hesitant about the mozconfig.lto change.
Attachment #9003411 - Flags: review?(core-build-config-reviews)
mozconfig.lto is only used by CI for the linux64-lto builds. We're going to have to deal with the issue of copy relocations somehow for bug 1481721 and that may or may not involve PIE.
Attachment #9003411 - Flags: review?(nfroyd)
Attachment #9003411 - Flags: review?(nfroyd) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d4ae67397e2
Avoid copy relocations in binaries we build. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/7d4ae67397e2
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1516830
You need to log in before you can comment on or make changes to this bug.