1485671 - Ensure that TabClient is used for all requests made to the TargetActors

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

A couple of requests sent to the Target actors like FrameTargetActor, which inherit from BrowsingContextActor, are being done manually, without using TabClient.
This is done by sending custom packet via `connection.send()`.

Here is a list of such usages:
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/framework/toolbox.js#2270-2274
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/framework/toolbox.js#2365-2372
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/framework/target.js#732-739
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/framework/target.js#754-761

There is also this one usage:
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/framework/target.js#432-441
But this one is special as we don't have any client class specific to the WebExtensionActor:
  https://searchfox.org/mozilla-central/source/devtools/server/actors/addon/webextension.js#93
This actor is returned by listAddons and we don't create any Client class out of it, instead we just pass around its form and uses form's metadata to display things in about:debugging UI:
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/aboutdebugging-new/src/reducers/runtime-state.js#70-91
And we pass this form to the TargetFactory.forRemoteTab as-is to create a TabTarget:
  https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/modules/addon.js#59-66
Whereas we should propably instanciate a dedicated Addon/WebExtension target class.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1485671 - Expose and use TabClient.logInPage instead of sending request manually. r=yulia

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1485671 - Expose and use TabClient.listFrames and switchToFrame. r=yulia

Depends On D6272

Comment 3

[Yulia Startsev [:yulia]]

Comment on attachment 9010300 [details]
Bug 1485671 - Expose and use TabClient.logInPage instead of sending request manually. r=yulia

Yulia Startsev [:yulia] has approved the revision.

Comment 4

[Yulia Startsev [:yulia]]

Comment on attachment 9010301 [details]
Bug 1485671 - Expose and use TabClient.listFrames and switchToFrame. r=yulia

Yulia Startsev [:yulia] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45e8b7393aac
Expose and use TabClient.logInPage instead of sending request manually. r=yulia
https://hg.mozilla.org/integration/autoland/rev/ef4ee8e17d32
Expose and use TabClient.listFrames and switchToFrame. r=yulia

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/45e8b7393aac
https://hg.mozilla.org/mozilla-central/rev/ef4ee8e17d32