1485694 - Fulltext search for reftest-wait is broken

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

If you search for reftest-wait you only get filenames back, not file contents.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Looks like it's particular for that query:

2018-08-23 15:15:44.940305/pid=23041 - QUERY line: "reftest\\-wait", file: "[^/]*\\.html", repo: "mozilla-central|mozilla-central-__GENERATED__", fold_case: true, 
2018-08-23 15:15:44.975211/pid=23041 - Got exception: <_Rendezvous of RPC that terminated with:
	status = StatusCode.INTERNAL
	details = "Exception deserializing response!"
	debug_error_string = "None"
>
2018-08-23 15:15:44.982739/pid=23040 - finish pid 23041 - 0.043531
2018-08-23 15:15:45.058422/pid=23044 - request(handled by 23045) /mozilla-central/search?q=reftest-wait&case=false&regexp=false&path=*.html
2018-08-23 15:15:45.059977/pid=23045 - QUERY line: "reftest\\-wait", file: "[^/]*\\.html", repo: "mozilla-central|mozilla-central-__GENERATED__", fold_case: true, 
2018-08-23 15:15:45.097843/pid=23045 - Got exception: <_Rendezvous of RPC that terminated with:
	status = StatusCode.INTERNAL
	details = "Exception deserializing response!"
	debug_error_string = "None"
>

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://github.com/grpc/grpc/issues/14847 could be related.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This might be due to a version mismatch of grpc on the serializing side (in livegrep) and the deserializing side (in python). The serializer is using grpc @ ca87867579580928ca4c9fdf97051fa25bf1d386 per the web-server's provision.log and the deserializing side is using grpcio==1.14.1 which is what gets installed by pip. At some point I'll try to figure out if these are the same and if not, we should have pip install a version that matches what livegrep is using and see if that fixes the problem.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Downgrading the grpcio and grpcio-tools packages to 1.7.0 didn't help, I still got the deserialization errors. That being said the serialization grpc revision is somewhere between 1.6.1 and 1.7.0 (there's a lot of changes between those two) so it's possible there's still a mismatch. Next thing to try is upgrading the version used by livegrep.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Using the latest livegrep master with protobuf/grpc bumped didn't fix it either. I'll debug.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This was fixed upstream by livegrep/livegrep#186. I've verified the fix on dev; will make a PR to update mozsearch accordingly.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozsearch/mozsearch/pull/139

Comment 9

[Kartikaya Gupta (email:[e-mail])]

The fix is deployed now (even though the PR hasn't merged yet, because deploying the fix just involved rebuilding the AMIs, which I did while testing anyway). I'll leave this open until the PR is merged.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Merged.