1485701 - add aarch64 windows support to the interceptor code

Status: RESOLVED FIXED

(Core :: mozglue, enhancement)

Description

[Nathan Froyd [:froydnj]]

I'm hitting errors like:

.../interceptor/PatcherDetour.h(56): fatal error C1189: #error:  "Unknown processor type"

which is expected, and appreciated that this code errors out.  There's some similar code in TargetFunction.h that needs to be tweaked as well, and maybe a few other files.

Is it reasonable to try and stub this code out on AArch64 for now, or do we really have to add actual interceptor support?

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Nathan Froyd [:froydnj] from comment #0)
> Is it reasonable to try and stub this code out on AArch64 for now, or do we
> really have to add actual interceptor support?

Yeah, go ahead and stub it out for now so that we return false. We would need interceptor support in order to ship, but I highly doubt that you would need it at this stage.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Aaron Klotz [:aklotz] from comment #1)
> (In reply to Nathan Froyd [:froydnj] from comment #0)
> > Is it reasonable to try and stub this code out on AArch64 for now, or do we
> > really have to add actual interceptor support?
> 
> Yeah, go ahead and stub it out for now so that we return false. We would
> need interceptor support in order to ship, but I highly doubt that you would
> need it at this stage.

Is there a particular toplevel place to return false to disable installing interceptors, or something like that?  I can add necessary constants for AArch64, and MOZ_ASSERT along codepaths that actually modify code, but it'd be nice if there was some toplevel place to just fail fast.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

This is the best place:

https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/mozglue/misc/nsWindowsDllInterceptor.h#450

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: make the interceptor code compilable, if not functional, on aarch64 windows

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/164224515766
make the interceptor code compilable, if not functional, on aarch64 windows; r=aklotz

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/164224515766