Closed Bug 1485701 Opened 2 years ago Closed 2 years ago

add aarch64 windows support to the interceptor code

Categories

(Core :: mozglue, enhancement)

ARM64
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm hitting errors like:

.../interceptor/PatcherDetour.h(56): fatal error C1189: #error:  "Unknown processor type"

which is expected, and appreciated that this code errors out.  There's some similar code in TargetFunction.h that needs to be tweaked as well, and maybe a few other files.

Is it reasonable to try and stub this code out on AArch64 for now, or do we really have to add actual interceptor support?
Flags: needinfo?(aklotz)
(In reply to Nathan Froyd [:froydnj] from comment #0)
> Is it reasonable to try and stub this code out on AArch64 for now, or do we
> really have to add actual interceptor support?

Yeah, go ahead and stub it out for now so that we return false. We would need interceptor support in order to ship, but I highly doubt that you would need it at this stage.
Flags: needinfo?(aklotz)
(In reply to Aaron Klotz [:aklotz] from comment #1)
> (In reply to Nathan Froyd [:froydnj] from comment #0)
> > Is it reasonable to try and stub this code out on AArch64 for now, or do we
> > really have to add actual interceptor support?
> 
> Yeah, go ahead and stub it out for now so that we return false. We would
> need interceptor support in order to ship, but I highly doubt that you would
> need it at this stage.

Is there a particular toplevel place to return false to disable installing interceptors, or something like that?  I can add necessary constants for AArch64, and MOZ_ASSERT along codepaths that actually modify code, but it'd be nice if there was some toplevel place to just fail fast.
Flags: needinfo?(aklotz)
Assignee: nobody → nfroyd
Attachment #9003853 - Flags: review?(aklotz) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/164224515766
make the interceptor code compilable, if not functional, on aarch64 windows; r=aklotz
https://hg.mozilla.org/mozilla-central/rev/164224515766
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1494392
You need to log in before you can comment on or make changes to this bug.