GeckoView: Allow to enable/disable JavaScript on session level

RESOLVED FIXED in Firefox 65

Status

enhancement
P2
normal
RESOLVED FIXED
9 months ago
5 months ago

People

(Reporter: sebastian, Assigned: fluffyemily)

Tracking

unspecified
mozilla65
All
Android

Firefox Tracking Flags

(geckoview64 wontfix, firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 fixed)

Details

Attachments

(2 attachments)

Currently we can only enable/disable JavaScript in GeckoRuntimeSettings. We would like to do that for individual sessions via GeckoSessionSettings.
Sebastian, is enabling/disabling JavaScript for individual sessions a release blocker for Focus+GV? Can Focus+WebView enable/disable JavaScript for individual tabs?
No release blocker.

You can do that in Focus right now - as a workaround we enable/disable JavaScript globally when switching tabs. That's a bit hacky but seems to work for now. We'd like to replace this with a more sane implementation though. :)
Flags: needinfo?(s.kaspari)
Priority: -- → P2
Assignee

Updated

7 months ago
Assignee: nobody → etoop

Comment 5

7 months ago
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/307ddcb2187b
Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen
Assignee

Comment 7

7 months ago
...la.com/D8093. This has now been closed so I cannot update it.
(In reply to Emily Toop (:fluffyemily) from comment #7)
> Created attachment 9021107 [details]
> Bug 1485718 - Enable setting of javascript on GeckoView sessions through
> `GeckoSessionSettings.` r=jchen
> 
> This is a resubmission due to issues landing old one. Not sure if this needs
> a re-review? Old review: https://phabricator.services.mozilla.
> 
> ...la.com/D8093. This has now been closed so I cannot update it.

If you want to use that phabricator revision again you can just reopen it. It's one of the choices in the "Add Action" dropdown at the bottom.
Attachment #9021107 - Attachment description: Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen This is a resubmission due to issues landing old one. Not sure if this needs a re-review? Old review: https://phabricator.services.mozilla. → Bug 1485718 - Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen

Comment 9

7 months ago
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cfb0bf7cb66
Enable setting of javascript on GeckoView sessions through `GeckoSessionSettings.` r=jchen

Comment 10

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9cfb0bf7cb66
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
64=wontfix because we don't need to uplift this fix for Focus 8.0's GV 64 beta test
Assignee

Updated

7 months ago
Flags: needinfo?(etoop)
status-geckoview64=wontfix

Updated

5 months ago
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.